From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Arno Steffen <arno.steffen@googlemail.com>
Subject: Re: [PATCH] omap3: feature: fix OMAP3_IVA_MASK
Date: Wed, 17 Nov 2010 05:35:36 -0600 [thread overview]
Message-ID: <4CE3BE08.208@ti.com> (raw)
In-Reply-To: <20101116212715.GK9264@atomide.com>
Tony Lindgren wrote, on 11/16/2010 03:27 PM:
> * Nishanth Menon<nm@ti.com> [101105 17:29]:
>> From: Arno Steffen<arno.steffen@googlemail.com>
>>
>> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
>>
>> Signed-off-by: Arno Steffen<arno.steffen@googlemail.com>
>> ---
>> Sending on behalf of Arno - he pointed at the change and everything
>> except for the patch ;)
>> Reported here:
>> http://marc.info/?l=linux-omap&m=128896969832702&w=2
>
> Hmm, until we have an official verbal-patch-to-unified-diff translator,
> I guess the right thing to do here is to make it be:
>
> From: Nishanth Menon<nm@ti.com>
>
> OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT
>
> Reported-by: Arno Steffen<arno.steffen@googlemail.com>
> Signed-off-by: Nishanth Menon<nm@ti.com>
>
> Can you please repost or confirm that's OK for you?
I would prefer if Arno resubmit the patch under his name - but if he
cannot do so, I can take ownership.
Arno,
please comment.
>
> Tony
>
>> arch/arm/mach-omap2/control.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
>> index b6c6b7c..5325297 100644
>> --- a/arch/arm/mach-omap2/control.h
>> +++ b/arch/arm/mach-omap2/control.h
>> @@ -309,7 +309,7 @@
>> #define FEAT_SGX_NONE 2
>>
>> #define OMAP3_IVA_SHIFT 12
>> -#define OMAP3_IVA_MASK (1<< OMAP3_SGX_SHIFT)
>> +#define OMAP3_IVA_MASK (1<< OMAP3_IVA_SHIFT)
>> #define FEAT_IVA 0
>> #define FEAT_IVA_NONE 1
>>
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2010-11-17 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 16:05 [PATCH] omap3: feature: fix OMAP3_IVA_MASK Nishanth Menon
2010-11-16 21:27 ` Tony Lindgren
2010-11-17 11:35 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE3BE08.208@ti.com \
--to=nm@ti.com \
--cc=arno.steffen@googlemail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox