From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH v2 6/8] usb: ehci-omap: add helpers for checking port mode
Date: Tue, 30 Nov 2010 15:25:50 +0300 [thread overview]
Message-ID: <4CF4ED4E.1080707@ru.mvista.com> (raw)
In-Reply-To: <1291051537-23743-7-git-send-email-gadiyar@ti.com>
Hello.
On 29-11-2010 20:25, Anand Gadiyar wrote:
> Introduce helper functions to test port mode. These checks are
> performed in several places in the driver, and these helpers
> improve readability.
> Signed-off-by: Anand Gadiyar<gadiyar@ti.com>
[...]
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 7a4682c..dd9d5c1 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
[...]
> @@ -387,27 +390,27 @@ static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
> /* Bypass the TLL module for PHY mode operation */
> if (cpu_is_omap3430()&& (omap_rev()<= OMAP3430_REV_ES2_1)) {
> dev_dbg(omap->dev, "OMAP3 ES version<= ES2.1\n");
> - if ((omap->port_mode[0] == EHCI_HCD_OMAP_MODE_PHY) ||
> - (omap->port_mode[1] == EHCI_HCD_OMAP_MODE_PHY) ||
> - (omap->port_mode[2] == EHCI_HCD_OMAP_MODE_PHY))
> + if (is_ehci_phy_mode(omap->port_mode[0]) ||
> + is_ehci_phy_mode(omap->port_mode[1]) ||
> + is_ehci_phy_mode(omap->port_mode[2]))
Why there's another indentation level whenre there shouldn't be one?
WBR, Sergei
next prev parent reply other threads:[~2010-11-30 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 17:25 [PATCH v2 0/8] usb: ehci-omap: add OMAP4 support Anand Gadiyar
2010-11-29 17:25 ` [PATCH v2 1/8] usb: ehci-omap: update clock names to be more generic Anand Gadiyar
2010-11-29 17:25 ` [PATCH v2 2/8] usb: ehci-omap: don't hard-code TLL channel count Anand Gadiyar
[not found] ` <1291051537-23743-1-git-send-email-gadiyar-l0cyMroinI0@public.gmane.org>
2010-11-29 17:25 ` [PATCH v2 3/8] usb: ehci: introduce CONFIG_USB_EHCI_HCD_OMAP Anand Gadiyar
2010-11-29 17:25 ` [PATCH v2 6/8] usb: ehci-omap: add helpers for checking port mode Anand Gadiyar
2010-11-30 12:25 ` Sergei Shtylyov [this message]
[not found] ` <4CF4ED4E.1080707-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-11-30 14:44 ` Anand Gadiyar
2010-11-30 14:49 ` Greg KH
2010-11-29 17:25 ` [PATCH v2 4/8] omap: clock: add clkdev aliases for EHCI clocks Anand Gadiyar
2010-11-29 18:40 ` Paul Walmsley
2010-11-29 17:25 ` [PATCH v2 5/8] usb: ehci-omap: use clkdev aliases for functional clocks Anand Gadiyar
2010-11-29 17:25 ` [PATCH v2 7/8] omap: usb: ehci: introduce HSIC mode Anand Gadiyar
2010-11-29 17:25 ` [PATCH v2 8/8] usb: ehci-omap: Add OMAP4 support Anand Gadiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF4ED4E.1080707@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=gadiyar@ti.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox