[PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[MING ZHOU]

Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
register definition for reset time is wrong according to spec of
OMAP4. And we verified this by reading default value of register. We
found the offset definition of Reset time and Reset Test register
should be switched. After correcting this bug, we verified by changing
the value of reset time register, the pulse generated for reset is
also changed as expected on scope.

>From 9a9c98c2f4008e5d8f2f5da1101e3bfe222a48ed Mon Sep 17 00:00:00 2001
From: Zhou Ming <a17711@motorola.com>
Date: Tue, 7 Dec 2010 10:00:59 -0500
Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
OMAP4_RM_RSTTIME

According to test result, we found the offset definition of OMAP4_RM_RSTST
and OMAP4_RM_RSTIME should be switched.
---
 arch/arm/mach-omap2/prm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/prm.h b/arch/arm/mach-omap2/prm.h
index 7be040b..23b4be2 100644
--- a/arch/arm/mach-omap2/prm.h
+++ b/arch/arm/mach-omap2/prm.h
@@ -222,8 +222,8 @@

 /* Omap4 specific registers */
 #define OMAP4_RM_RSTCTRL                               0x0000
-#define OMAP4_RM_RSTTIME                               0x0004
-#define OMAP4_RM_RSTST                                 0x0008
+#define OMAP4_RM_RSTTIME                               0x0008
+#define OMAP4_RM_RSTST                                 0x0004
 #define OMAP4_PM_PWSTCTRL                              0x0000
 #define OMAP4_PM_PWSTST                                        0x0004

RE: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[Santosh Shilimkar]

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of MING ZHOU
> Sent: Tuesday, December 07, 2010 1:04 PM
> To: linux-omap@vger.kernel.org
> Cc: Tony Lindgren; Paul Walmsley
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
> register definition for reset time is wrong according to spec of
> OMAP4. And we verified this by reading default value of register. We
> found the offset definition of Reset time and Reset Test register
> should be switched. After correcting this bug, we verified by changing
> the value of reset time register, the pulse generated for reset is
> also changed as expected on scope.
>
> From 9a9c98c2f4008e5d8f2f5da1101e3bfe222a48ed Mon Sep 17 00:00:00 2001
> From: Zhou Ming <a17711@motorola.com>
> Date: Tue, 7 Dec 2010 10:00:59 -0500
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> According to test result, we found the offset definition of
OMAP4_RM_RSTST
> and OMAP4_RM_RSTIME should be switched.
> ---
>  arch/arm/mach-omap2/prm.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm.h b/arch/arm/mach-omap2/prm.h
> index 7be040b..23b4be2 100644
> --- a/arch/arm/mach-omap2/prm.h
> +++ b/arch/arm/mach-omap2/prm.h
> @@ -222,8 +222,8 @@
>
>  /* Omap4 specific registers */
>  #define OMAP4_RM_RSTCTRL                               0x0000
> -#define OMAP4_RM_RSTTIME                               0x0004
> -#define OMAP4_RM_RSTST                                 0x0008
> +#define OMAP4_RM_RSTTIME                               0x0008
> +#define OMAP4_RM_RSTST                                 0x0004
Yep. This is indeed correct offsets.

>  #define OMAP4_PM_PWSTCTRL                              0x0000
>  #define OMAP4_PM_PWSTST                                        0x0004
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[Paul Walmsley]

Hello,

On Tue, 7 Dec 2010, MING ZHOU wrote:

> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
> register definition for reset time is wrong according to spec of
> OMAP4. And we verified this by reading default value of register. We
> found the offset definition of Reset time and Reset Test register
> should be switched. After correcting this bug, we verified by changing
> the value of reset time register, the pulse generated for reset is
> also changed as expected on scope.

Thanks, will queue this for 2.6.38 since it looks like there are no 
in-tree users in 2.6.37.


- Paul

Re: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[Cousson, Benoit]

Hi Paul,

On 12/7/2010 5:04 PM, Paul Walmsley wrote:
> Hello,
>
> On Tue, 7 Dec 2010, MING ZHOU wrote:
>
>> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
>> register definition for reset time is wrong according to spec of
>> OMAP4. And we verified this by reading default value of register. We
>> found the offset definition of Reset time and Reset Test register
>> should be switched. After correcting this bug, we verified by changing
>> the value of reset time register, the pulse generated for reset is
>> also changed as expected on scope.
>
> Thanks, will queue this for 2.6.38 since it looks like there are no
> in-tree users in 2.6.37.

These defines are not needed anymore, it is legacy stuff done before we 
generated the whole prm44xx.h.

Here are the entries in the prm44xx.h, line 574.

/* PRM.DEVICE_PRM register offsets */
#define OMAP4_PRM_RSTCTRL_OFFSET			0x0000
#define OMAP4_PRM_RSTST_OFFSET				0x0004
#define OMAP4_PRM_RSTTIME_OFFSET			0x0008


We'd better get rid of these old entries in prm.h

Regards,
Benoit