From: David Anders <x0132446@ti.com>
To: "Murthy, Raghuveer" <raghuveer.murthy@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line
Date: Wed, 08 Dec 2010 10:49:08 -0600 [thread overview]
Message-ID: <4CFFB704.3030905@ti.com> (raw)
In-Reply-To: <1291723986-24658-1-git-send-email-raghuveer.murthy@ti.com>
On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
> will default to zero. On Pandaboard this interferes with gpio line
> assigned for powering TFP410 DVI chip.
>
> This fix was missed out in the previous commit bf56f0a6668cd, from
> Nishanth Menon
>
> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
> Acked-by: Nishanth Menon<nm@ti.com>
>
Tested-by: David Anders <x0132446@ti.com>
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index ad6b5cc..0ccc24f 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -142,6 +142,7 @@ static struct omap2_hsmmc_info mmc[] = {
> .mmc = 1,
> .caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
> .gpio_wp = -EINVAL,
> + .gpio_cd = -EINVAL,
> },
> {} /* Terminator */
> };
>
next prev parent reply other threads:[~2010-12-08 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 12:13 [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line Raghuveer Murthy
2010-12-08 16:49 ` David Anders [this message]
2010-12-17 17:50 ` Menon, Nishanth
2010-12-17 18:02 ` Tony Lindgren
2010-12-17 18:06 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFFB704.3030905@ti.com \
--to=x0132446@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=raghuveer.murthy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox