[PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[Raghuveer Murthy]

The .gpio_cd member of omap2_hsmmc_info is not initialized. This
will default to zero. On Pandaboard this interferes with gpio line
assigned for powering TFP410 DVI chip.

This fix was missed out in the previous commit bf56f0a6668cd, from
Nishanth Menon

Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
Signed-off-by: Raghuveer Murthy <raghuveer.murthy@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/mach-omap2/board-omap4panda.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index ad6b5cc..0ccc24f 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -142,6 +142,7 @@ static struct omap2_hsmmc_info mmc[] = {
 		.mmc		= 1,
 		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
 		.gpio_wp	= -EINVAL,
+		.gpio_cd	= -EINVAL,
 	},
 	{}	/* Terminator */
 };
-- 
1.7.0.4

Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[David Anders]

On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
> will default to zero. On Pandaboard this interferes with gpio line
> assigned for powering TFP410 DVI chip.
>
> This fix was missed out in the previous commit bf56f0a6668cd, from
> Nishanth Menon
>
> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
> Acked-by: Nishanth Menon<nm@ti.com>
>    

Tested-by: David Anders <x0132446@ti.com>

> ---
>   arch/arm/mach-omap2/board-omap4panda.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index ad6b5cc..0ccc24f 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -142,6 +142,7 @@ static struct omap2_hsmmc_info mmc[] = {
>   		.mmc		= 1,
>   		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
>   		.gpio_wp	= -EINVAL,
> +		.gpio_cd	= -EINVAL,
>   	},
>   	{}	/* Terminator */
>   };
>    

Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[Menon, Nishanth]

On Wed, Dec 8, 2010 at 10:49, David Anders <x0132446@ti.com> wrote:
> On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
>>
>> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
>> will default to zero. On Pandaboard this interferes with gpio line
>> assigned for powering TFP410 DVI chip.
>>
>> This fix was missed out in the previous commit bf56f0a6668cd, from
>> Nishanth Menon
>>
>> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
>> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
>> Acked-by: Nishanth Menon<nm@ti.com>
>>
>
> Tested-by: David Anders <x0132446@ti.com>
Tony,
this is a regression introduced in my commit for .37-rc1. any chance
of this making to one of 37 rc cycles? I can re-post this patch
including l-a if that is the path you'd like.

Regards,
Nishanth Menon


>
>> ---
>>  arch/arm/mach-omap2/board-omap4panda.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap4panda.c
>> b/arch/arm/mach-omap2/board-omap4panda.c
>> index ad6b5cc..0ccc24f 100644
>> --- a/arch/arm/mach-omap2/board-omap4panda.c
>> +++ b/arch/arm/mach-omap2/board-omap4panda.c
>> @@ -142,6 +142,7 @@ static struct omap2_hsmmc_info mmc[] = {
>>                .mmc            = 1,
>>                .caps           = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
>>                .gpio_wp        = -EINVAL,
>> +               .gpio_cd        = -EINVAL,
>>        },
>>        {}      /* Terminator */
>>  };
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[Tony Lindgren]

* Menon, Nishanth <nm@ti.com> [101217 09:50]:
> On Wed, Dec 8, 2010 at 10:49, David Anders <x0132446@ti.com> wrote:
> > On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
> >>
> >> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
> >> will default to zero. On Pandaboard this interferes with gpio line
> >> assigned for powering TFP410 DVI chip.
> >>
> >> This fix was missed out in the previous commit bf56f0a6668cd, from
> >> Nishanth Menon
> >>
> >> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
> >> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
> >> Acked-by: Nishanth Menon<nm@ti.com>
> >>
> >
> > Tested-by: David Anders <x0132446@ti.com>
> Tony,
> this is a regression introduced in my commit for .37-rc1. any chance
> of this making to one of 37 rc cycles? I can re-post this patch
> including l-a if that is the path you'd like.

Yes please, and also explain what exactly this breaks.

If it just breaks MMC card detect with some DVI chip driver that's
not merged yet, then this would be in the "it never worked before".

Tony

Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[Nishanth Menon]

Tony Lindgren had written, on 12/17/2010 12:02 PM, the following:
> * Menon, Nishanth <nm@ti.com> [101217 09:50]:
>> On Wed, Dec 8, 2010 at 10:49, David Anders <x0132446@ti.com> wrote:
>>> On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
>>>> The .gpio_cd member of omap2_hsmmc_info is not initialized. This
>>>> will default to zero. On Pandaboard this interferes with gpio line
>>>> assigned for powering TFP410 DVI chip.
>>>>
>>>> This fix was missed out in the previous commit bf56f0a6668cd, from
>>>> Nishanth Menon
>>>>
>>>> Signed-off-by: Kishore Kadiyala<kishore.kadiyala@ti.com>
>>>> Signed-off-by: Raghuveer Murthy<raghuveer.murthy@ti.com>
>>>> Acked-by: Nishanth Menon<nm@ti.com>
>>>>
>>> Tested-by: David Anders <x0132446@ti.com>
>> Tony,
>> this is a regression introduced in my commit for .37-rc1. any chance
>> of this making to one of 37 rc cycles? I can re-post this patch
>> including l-a if that is the path you'd like.
> 
> Yes please, and also explain what exactly this breaks.
> 
> If it just breaks MMC card detect with some DVI chip driver that's
> not merged yet, then this would be in the "it never worked before".
The regression is card detect ends up refering to a valid GPIO -> yeah 
as a result the upcoming DVI driver is broken without this patch. given 
that commit bf56f0a6668cd was intended to fix cd, it did not do it 
cleanly - hence my claim of regression. DVI in opinion is just a symptom 
of the wiring of GPIO0 on the board.

ok with considering this a regression?

-- 
Regards,
Nishanth Menon