public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: tom.leiming@gmail.com
Cc: tony@atomide.com, balbi@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: omap4: panda: fix initialize musb
Date: Thu, 09 Dec 2010 11:21:44 -0600	[thread overview]
Message-ID: <4D011028.6020505@ti.com> (raw)
In-Reply-To: <1291914170-25415-1-git-send-email-tom.leiming@gmail.com>

tom.leiming@gmail.com had written, on 12/09/2010 11:02 AM, the following:
> From: Ming Lei <tom.leiming@gmail.com>
> 
> Obviously we should only initialize musb once.
> 
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
>  arch/arm/mach-omap2/board-omap4panda.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 22599fc..85371be 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -393,9 +393,6 @@ static void __init omap4_panda_init(void)
>  	usb_nop_xceiv_register();
>  	omap4_ehci_init();
>  	usb_musb_init(&musb_board_data);
> -	/* FIXME: allow multi-omap to boot until musb is updated for omap4 */
> -	if (!cpu_is_omap44xx())
> -		usb_musb_init(&musb_board_data);
>  }
>  
>  static void __init omap4_panda_map_io(void)
Looks good to me. since this is for l-o master branch, I think this 
should probably be squashed to:

commit ec787afd05aad0cdb0b0d2948b356569805e5b30
Author: Felipe Balbi <balbi@ti.com>
Date:   Wed Dec 1 13:48:54 2010 +0200

     arm: omap4: panda: initialize musb

     initialize the musb port on pandaboard.

     Signed-off-by: Felipe Balbi <balbi@ti.com>

Regards,
Nishanth Menon

  reply	other threads:[~2010-12-09 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 17:02 [PATCH] arm: omap4: panda: fix initialize musb tom.leiming
2010-12-09 17:21 ` Nishanth Menon [this message]
2010-12-10  8:21   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D011028.6020505@ti.com \
    --to=nm@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox