From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Kevin Hilman <khilman@deeprootsystems.com>, Hema HK <hemahk@ti.com>
Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
Paul Walmsley <paul@pwsan.com>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v4] usb: musb: Adding names for IRQs in resource structure
Date: Thu, 09 Dec 2010 22:34:04 +0300 [thread overview]
Message-ID: <4D012F2C.9060303@ru.mvista.com> (raw)
In-Reply-To: <8762xo62b5.fsf@deeprootsystems.com>
Hello.
Kevin Hilman wrote:
>> The resource data is getting automatically populated from a set of data
>> generated from TI's hardware database for the OMAP platform,
>> While we could hack in some exceptions to that tool to generate resources
>> in a specific order, it seems less fragile to use the resource name
>> instead.That way, no matter what order the resources are generated, the
>> driver still work.
>> Modified the OMAP,Blackfin and Davinci architecture files to add the name of the IRQs
>> in the resource structures and musb driver to use the get_irq_byname() api to
>> get the device and dma irq numbers instead of using the index.
>> Signed-off-by: Hema HK <hemahk@ti.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Kevin Hilman <khilman@deeprootsystems.com>
>> Cc: Cousson, Benoit <b-cousson@ti.com>
>> Cc: Paul Walmsley <paul@pwsan.com>
>> Cc: Mike Frysinger <vapier@gentoo.org>
>> ---
> For the davinci changes:
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> Kevin
[...]
>> Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
>> ===================================================================
>> --- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
>> +++ linux-omap-pm/arch/arm/mach-davinci/usb.c
>> @@ -64,10 +64,12 @@ static struct resource usb_resources[] =
>> {
>> .start = IRQ_USBINT,
>> .flags = IORESOURCE_IRQ,
>> + .name = "mc"
>> },
>> {
>> /* placeholder for the dedicated CPPI IRQ */
>> .flags = IORESOURCE_IRQ,
>> + .name = "dma"
>> },
>> };
Argh! This failed to also modify da8xx_usb20_resources[]... :-(
WBR, Sergei
next prev parent reply other threads:[~2010-12-09 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 16:26 [PATCH v4] usb: musb: Adding names for IRQs in resource structure Hema HK
2010-09-29 6:59 ` Felipe Balbi
2010-09-29 8:54 ` Kalliguddi, Hema
2010-09-29 10:11 ` Felipe Balbi
2010-09-29 11:38 ` Kalliguddi, Hema
2010-09-29 13:48 ` Mike Frysinger
[not found] ` <1285777599-24245-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2010-09-29 14:40 ` Kevin Hilman
2010-12-09 19:34 ` Sergei Shtylyov [this message]
[not found] ` <4D012F2C.9060303-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-12-10 4:46 ` Kalliguddi, Hema
[not found] ` <AANLkTimF3Eotqa+jZvzCJStguGrDEeS9V-XUGOTa9qBt-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-10 12:56 ` Sergei Shtylyov
[not found] ` <4D02237B.2070708-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-12-10 13:20 ` Kalliguddi, Hema
2010-12-10 13:20 ` Felipe Balbi
[not found] ` <20101210132053.GN6027-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2010-12-10 13:35 ` Sergei Shtylyov
[not found] ` <4D022C92.7090308-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-12-10 13:58 ` Felipe Balbi
2010-12-10 16:43 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D012F2C.9060303@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=hemahk@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).