Re: pm-core broken

[Nishanth Menon <nm@ti.com>]

Kevin Hilman had written, on 12/16/2010 10:36 AM, the following:
> Nishanth Menon <nm@ti.com> writes:
> 
>> Hi Kevin,
>>
>> Just fyi, I tested pm-core(no patches of mine) against SDP3430(ES3.1)
>> and Beagle Rev C1(ES3.0) (that is the only board I could dig up): both
>> fail - I think basically <3630 is broken atm!.
>>
>> Beagleboard:
>> with omap2plus_defconfig + MLO, u-boot.bin from
>> http://www.angstrom-distribution.org/demo/beagleboard/
>> filesystem is a minimal busybox that I had built and init=/bin/sh to
>> prevent any other apps running in the background - I use the same on
>> SDP3630 and 3430 platforms.
>>
>> branch: pm-core (from your tree).
>> defconfig: omap2plus_defconfig - no changes other than disable RM680
>> board - currently causes a build failure.
> 
> At least for Beagle (and I assume it's same for SDP, but don't have one
> to test with) the problem is that u-boot leaves the USB OTG block in a
> state that does not idle, and thus prevents CORE from hitting RET.
> 
> The solution: ensure the USB OTG block is reset.
> 
> Also in my tree, threre is an usb-otg-reset branch which you can merge
> with pm-core to test if this helps.
> 
> Until we have the USB OTG hwmod conversion merged, this temporary hack
> is needed.  After conversion to hwmod, all hwmod will be reset during
> boot so we are not affected by bootloader (mis)behavior.

Arrgh.. we have some sort of regression for .37 formal release (off will 
probably broken as a result without these patches no for mainline 
bootloaders/custom bootloaders that dont understand the dependency 
clearly?).

Anyways, with the 5 patches in usb-otg-reset - test results:
SDP3630 (ES1.0):
SUSPEND:OFF test | PASS | OFF: 0->1| RET:0 ->0 (8 sec)
SUSPEND:RET test | PASS | OFF: 1->1| RET:0 ->1 (6 sec)
IDLE:OFF test | PASS | OFF: 1->22| RET:1 ->1 (21 sec)
IDLE:RET test | PASS | OFF: 22->22| RET:1 ->24 (21 sec)

SDP3430 (ES3.1):
SUSPEND:OFF test | PASS | OFF: 0->1| RET:0 ->0 (7 sec) 

SUSPEND:RET test | PASS | OFF: 1->1| RET:0 ->1 (6 sec) 

IDLE:OFF test | PASS | OFF: 1->21| RET:1 ->1 (22 sec) 

IDLE:RET test | PASS | OFF: 21->21| RET:1 ->23 (21 sec)

Beagle C1 (ES3.0):
SUSPEND:OFF test | FAIL | OFF: 0->0| RET:0 ->0 (6 sec) 

SUSPEND:RET test | FAIL | OFF: 0->0| RET:0 ->0 (6 sec) 

IDLE:OFF test | FAIL | OFF: 0->0| RET:0 ->0 (21 sec) 

IDLE:RET test | FAIL | OFF: 0->0| RET:0 ->0 (21 sec)


-- 
Regards,
Nishanth Menon