From: Nishanth Menon <nm@ti.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM
Date: Sun, 19 Dec 2010 09:22:33 -0600 [thread overview]
Message-ID: <4D0E2339.40401@ti.com> (raw)
In-Reply-To: <24FA44A2-FF60-4DA5-B672-66F501E297F6@dominion.thruhere.net>
Koen Kooi wrote, on 12/19/2010 08:56 AM:
>
> Op 19 dec 2010, om 15:47 heeft Nishanth Menon het volgende geschreven:
>
>> Koen Kooi wrote, on 12/19/2010 08:42 AM:
>> $subject - should'nt you be doing this in separate patches? easier to track with git bisect at a later date than a whole sale change?
>
> Is that really needed?
it is usually recommended to keep each separate functionality
introduced/fixed independent of the other.
>
>> btw, why are we enabling camera here? should'nt that be done in camera's probe function? no?
>
> On P7/P8 it's the camera, but on A2 and above it's the LDO that powers the TFP410, so if you want to have output on DVI you need to turn it on.
>I'm not sure if it should be part of the DVI init since it has
different functions on different board revisions.
P7/P8 were not production Beagles if my memory serves me right.. DVI
init makes more sense to me.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-12-19 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 12:40 [PATCH] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM Koen Kooi
2010-12-07 12:54 ` Koen Kooi
2010-12-14 14:11 ` Koen Kooi
2010-12-14 14:24 ` Anand Gadiyar
2010-12-18 2:07 ` Tony Lindgren
2010-12-18 8:22 ` Koen Kooi
2010-12-19 14:42 ` [PATCH v2] " Koen Kooi
2010-12-19 14:47 ` Nishanth Menon
2010-12-19 14:56 ` Koen Kooi
2010-12-19 15:22 ` Nishanth Menon [this message]
2010-12-20 18:48 ` Kevin Hilman
2011-01-06 18:29 ` Nishanth Menon
2011-01-06 18:33 ` Koen Kooi
2011-01-06 19:53 ` Coley, Gerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0E2339.40401@ti.com \
--to=nm@ti.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).