From: "Cousson, Benoit" <b-cousson@ti.com>
To: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 12/12] OMAP2: dmtimer: set wakeup enable explicitly in plat
Date: Tue, 21 Dec 2010 00:11:35 +0100 [thread overview]
Message-ID: <4D0FE2A7.2000506@ti.com> (raw)
In-Reply-To: <1292882719-30255-13-git-send-email-tarun.kanti@ti.com>
Hi Tarun,
On 12/20/2010 11:05 PM, DebBarma, Tarun Kanti wrote:
> For some reason the wakeup enable bit is not getting set on OMAP2430,
> OMAP2420. This is inspite of the fact that SYSC_HAS_ENAWAKEUP flag is
> present in the hwmod database.
This is indeed strange. Did you observe that on OMAP3 & 4?
Did you use the patch that Kevin did recently to fix an issue with the
ENAWAKEUP bit?
http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=commit;h=d15ae13fc7428a95b02c1935ebf92324fcb80a5f
The point is that this fix is not really acceptable for my point of view:-(
You really have to check what is going on in the hwmod _enable_wakeup
function.
Regards,
Benoit
>
> I am not sure if there is already a patch to fix this problem. Until the
> reason is found we need this patch to boot on the above platforms.
>
> Signed-off-by: Tarun Kanti DebBarma<tarun.kanti@ti.com>
> ---
> arch/arm/plat-omap/dmtimer.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index f4aa4a1..007b754 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -227,6 +227,7 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
>
> static void omap_dm_timer_prepare(struct omap_dm_timer *timer)
> {
> + u32 l;
> struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
>
> if (!pdata->is_omap16xx) {
> @@ -243,6 +244,18 @@ static void omap_dm_timer_prepare(struct omap_dm_timer *timer)
> if (pdata->dm_timer_reset)
> pdata->dm_timer_reset(timer);
>
> + /*
> + * Enable wake-up on OMAP2420, OMAP2430 CPUs.
> + * FIXME: SYSC_HAS_ENAWAKEUP flag is already set in hwmod database.
> + * But the setting does not seem to work. Need to investigate why
> + * this is happening.
> + */
> + if (cpu_is_omap2430() || cpu_is_omap2420()) {
> + l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> + l |= 1<< 2;
> + omap_dm_timer_write_reg(timer, OMAP_TIMER_OCP_CFG_REG, l);
> + }
> +
> omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
>
> /* Match hardware reset default of posted mode */
next prev parent reply other threads:[~2010-12-20 23:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 22:05 [PATCH v7 0/12] dmtimer adaptation to platform_driver Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 1/12] OMAP2+: dmtimer: add device names to flck nodes Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 2/12] OMAP2420: hwmod data: add dmtimer Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 3/12] OMAP2430: " Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 4/12] OMAP3: " Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 5/12] OMAP4: " Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 6/12] OMAP1: dmtimer: conversion to platform devices Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 7/12] OMAP2+: dmtimer: convert " Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 8/12] OMAP: dmtimer: platform driver Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 9/12] OMAP: dmtimer: switch-over to platform device driver Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 10/12] OMAP: dmtimer: pm_runtime support Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 11/12] OMAP: dmtimer: add timeout to low-level routines Tarun Kanti DebBarma
2010-12-20 22:05 ` [PATCH v7 12/12] OMAP2: dmtimer: set wakeup enable explicitly in plat Tarun Kanti DebBarma
2010-12-20 23:11 ` Cousson, Benoit [this message]
2010-12-20 23:46 ` Kevin Hilman
2010-12-22 11:31 ` DebBarma, Tarun Kanti
2010-12-23 10:52 ` DebBarma, Tarun Kanti
2011-01-03 7:31 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FE2A7.2000506@ti.com \
--to=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox