From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared Date: Tue, 04 Jan 2011 12:49:04 -0600 Message-ID: <4D236BA0.8010002@ti.com> References: <1294165576-15628-1-git-send-email-santosh.shilimkar@ti.com> <1294165576-15628-2-git-send-email-santosh.shilimkar@ti.com> <1294165576-15628-3-git-send-email-santosh.shilimkar@ti.com> <1294165576-15628-4-git-send-email-santosh.shilimkar@ti.com> <1294165576-15628-5-git-send-email-santosh.shilimkar@ti.com> <1294165576-15628-6-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:35901 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638Ab1ADStJ (ORCPT ); Tue, 4 Jan 2011 13:49:09 -0500 Received: by mail-gw0-f53.google.com with SMTP id 10so4976098gwb.40 for ; Tue, 04 Jan 2011 10:49:08 -0800 (PST) In-Reply-To: <1294165576-15628-6-git-send-email-santosh.shilimkar@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, khilman@ti.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Thara Gopinath , Kevin Hilman Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following: > CC arch/arm/mach-omap2/omap_hwmod_common_data.o > In file included from arch/arm/plat-omap/include/plat/omap_hwmod.h:38, > from arch/arm/mach-omap2/omap_hwmod_common_data.c:20: > arch/arm/plat-omap/include/plat/voltage.h: In function 'omap_voltage_late_init': > arch/arm/plat-omap/include/plat/voltage.h:145: error: 'EINVAL' undeclared (first use in this function) > arch/arm/plat-omap/include/plat/voltage.h:145: error: (Each undeclared identifier is reported only once > arch/arm/plat-omap/include/plat/voltage.h:145: error: for each function it appears in.) > make[1]: *** [arch/arm/mach-omap2/omap_hwmod_common_data.o] Error 1 > make: *** [arch/arm/mach-omap2] Error 2 > > The error is reported when omap2plus_defconfig built with CONFIG_PM disabled > > Signed-off-by: Santosh Shilimkar > Cc: Thara Gopinath > Cc: Kevin Hilman > --- > arch/arm/plat-omap/include/plat/voltage.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h > index c095351..2b776f0 100644 > --- a/arch/arm/plat-omap/include/plat/voltage.h > +++ b/arch/arm/plat-omap/include/plat/voltage.h > @@ -14,6 +14,8 @@ > #ifndef __ARCH_ARM_MACH_OMAP2_VOLTAGE_H > #define __ARCH_ARM_MACH_OMAP2_VOLTAGE_H > > +#include > + Not sure if this is better OR including the err.h in c files is better, since the c file is the location where the error code is actually used.. but no strong feelings about either personally. [..] -- Regards, Nishanth Menon