From: Nishanth Menon <nm@ti.com>
To: Koen Kooi <koen.kooi@gmail.com>
Cc: linux-omap@vger.kernel.org,
Koen Kooi <koen@dominion.thruhere.net>,
Koen Kooi <koen@beagleboard.org>
Subject: Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM
Date: Thu, 06 Jan 2011 12:29:10 -0600 [thread overview]
Message-ID: <4D2609F6.8090204@ti.com> (raw)
In-Reply-To: <1292769735-54159-1-git-send-email-koen@dominion.thruhere.net>
Koen,
Apologies on a late response.
Koen Kooi had written, on 12/19/2010 08:42 AM, the following:
[...]
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f1a8ede..4756ac7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
[..]
> +
> + /* Power on DVI, Serial and PWR led */
> + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
> + gpio_request(gpio + 1, "nDVI_PWR_EN");
> + gpio_direction_output(gpio + 1, 0);
> + }
earlier in this function, we do:
gpio_request(gpio + 1, "EHCI_nOC");
gpio_direction_input(gpio + 1);
here we do
gpio_request(gpio + 1, "nDVI_PWR_EN");
gpio_direction_output(gpio + 1, 0);
I am confused. is gpio+1 input or output line? and what level should it
be on?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-06 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 12:40 [PATCH] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM Koen Kooi
2010-12-07 12:54 ` Koen Kooi
2010-12-14 14:11 ` Koen Kooi
2010-12-14 14:24 ` Anand Gadiyar
2010-12-18 2:07 ` Tony Lindgren
2010-12-18 8:22 ` Koen Kooi
2010-12-19 14:42 ` [PATCH v2] " Koen Kooi
2010-12-19 14:47 ` Nishanth Menon
2010-12-19 14:56 ` Koen Kooi
2010-12-19 15:22 ` Nishanth Menon
2010-12-20 18:48 ` Kevin Hilman
2011-01-06 18:29 ` Nishanth Menon [this message]
2011-01-06 18:33 ` Koen Kooi
2011-01-06 19:53 ` Coley, Gerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2609F6.8090204@ti.com \
--to=nm@ti.com \
--cc=koen.kooi@gmail.com \
--cc=koen@beagleboard.org \
--cc=koen@dominion.thruhere.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).