From: Nishanth Menon <nm@ti.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>,
Koen Kooi <koen@beagleboard.org>
Subject: Re: omap: Beagle: detect new xM revision B
Date: Fri, 07 Jan 2011 07:03:30 -0600 [thread overview]
Message-ID: <4D270F22.7050703@ti.com> (raw)
In-Reply-To: <1294391413-3612-1-git-send-email-koen@dominion.thruhere.net>
Koen Kooi wrote, on 01/07/2011 03:10 AM:
> From: Robert Nelson<robertcnelson@gmail.com>
>
> The xM B uses a DM3730 ES1.1 over the ES1.0 on xM A's, no other board changes.
unrelated to patch: funny why the GPIO version changed then!
related to patch: please add [PATCH] in $subject.. minor comment follows:
>
> Signed-off-by: Robert Nelson<robertcnelson@gmail.com>
> Signed-off-by: Koen Kooi<koen@beagleboard.org>
> ---
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 7c82730..4fd73e7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -58,7 +58,8 @@
> * AXBX = GPIO173, GPIO172, GPIO171: 1 1 1
> * C1_3 = GPIO173, GPIO172, GPIO171: 1 1 0
> * C4 = GPIO173, GPIO172, GPIO171: 1 0 1
> - * XM = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMA = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMB = GPIO173, GPIO172, GPIO171: 0 0 1
> */
> enum {
> OMAP3BEAGLE_BOARD_UNKN = 0,
> @@ -117,7 +118,11 @@ static void __init omap3_beagle_init_rev(void)
> omap3_beagle_version = OMAP3BEAGLE_BOARD_C4;
> break;
> case 0:
> - printk(KERN_INFO "OMAP3 Beagle Rev: xM\n");
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM A\n");
> + omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> + break;
> + case 1:
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM B\n");
could you replace printk(KERN_INFO with pr_info?
> omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> break;
> default:
> --
> cgit v0.8.3.1-30-gff3a
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2011-01-07 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 9:10 omap: Beagle: detect new xM revision B Koen Kooi
2011-01-07 13:03 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D270F22.7050703@ti.com \
--to=nm@ti.com \
--cc=koen@beagleboard.org \
--cc=koen@dominion.thruhere.net \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox