* omap: Beagle: detect new xM revision B
@ 2011-01-07 9:10 Koen Kooi
2011-01-07 13:03 ` Nishanth Menon
0 siblings, 1 reply; 2+ messages in thread
From: Koen Kooi @ 2011-01-07 9:10 UTC (permalink / raw)
To: linux-omap; +Cc: Robert Nelson, Koen Kooi
From: Robert Nelson <robertcnelson@gmail.com>
The xM B uses a DM3730 ES1.1 over the ES1.0 on xM A's, no other board changes.
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Koen Kooi <koen@beagleboard.org>
---
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 7c82730..4fd73e7 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -58,7 +58,8 @@
* AXBX = GPIO173, GPIO172, GPIO171: 1 1 1
* C1_3 = GPIO173, GPIO172, GPIO171: 1 1 0
* C4 = GPIO173, GPIO172, GPIO171: 1 0 1
- * XM = GPIO173, GPIO172, GPIO171: 0 0 0
+ * XMA = GPIO173, GPIO172, GPIO171: 0 0 0
+ * XMB = GPIO173, GPIO172, GPIO171: 0 0 1
*/
enum {
OMAP3BEAGLE_BOARD_UNKN = 0,
@@ -117,7 +118,11 @@ static void __init omap3_beagle_init_rev(void)
omap3_beagle_version = OMAP3BEAGLE_BOARD_C4;
break;
case 0:
- printk(KERN_INFO "OMAP3 Beagle Rev: xM\n");
+ printk(KERN_INFO "OMAP3 Beagle Rev: xM A\n");
+ omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
+ break;
+ case 1:
+ printk(KERN_INFO "OMAP3 Beagle Rev: xM B\n");
omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
break;
default:
--
cgit v0.8.3.1-30-gff3a
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: omap: Beagle: detect new xM revision B
2011-01-07 9:10 omap: Beagle: detect new xM revision B Koen Kooi
@ 2011-01-07 13:03 ` Nishanth Menon
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2011-01-07 13:03 UTC (permalink / raw)
To: Koen Kooi; +Cc: linux-omap, Robert Nelson, Koen Kooi
Koen Kooi wrote, on 01/07/2011 03:10 AM:
> From: Robert Nelson<robertcnelson@gmail.com>
>
> The xM B uses a DM3730 ES1.1 over the ES1.0 on xM A's, no other board changes.
unrelated to patch: funny why the GPIO version changed then!
related to patch: please add [PATCH] in $subject.. minor comment follows:
>
> Signed-off-by: Robert Nelson<robertcnelson@gmail.com>
> Signed-off-by: Koen Kooi<koen@beagleboard.org>
> ---
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 7c82730..4fd73e7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -58,7 +58,8 @@
> * AXBX = GPIO173, GPIO172, GPIO171: 1 1 1
> * C1_3 = GPIO173, GPIO172, GPIO171: 1 1 0
> * C4 = GPIO173, GPIO172, GPIO171: 1 0 1
> - * XM = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMA = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMB = GPIO173, GPIO172, GPIO171: 0 0 1
> */
> enum {
> OMAP3BEAGLE_BOARD_UNKN = 0,
> @@ -117,7 +118,11 @@ static void __init omap3_beagle_init_rev(void)
> omap3_beagle_version = OMAP3BEAGLE_BOARD_C4;
> break;
> case 0:
> - printk(KERN_INFO "OMAP3 Beagle Rev: xM\n");
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM A\n");
> + omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> + break;
> + case 1:
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM B\n");
could you replace printk(KERN_INFO with pr_info?
> omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> break;
> default:
> --
> cgit v0.8.3.1-30-gff3a
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-07 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-07 9:10 omap: Beagle: detect new xM revision B Koen Kooi
2011-01-07 13:03 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox