Re: omap: Beagle: detect new xM revision B

Nishanth Menon
2011-01-07T13:03:45Z

Koen Kooi wrote, on 01/07/2011 03:10 AM:
> From: Robert Nelson<robertcnelson@gmail.com>
>
> The xM B uses a DM3730 ES1.1 over the ES1.0 on xM A's, no other board changes.

unrelated to patch: funny why the GPIO version changed then!

related to patch: please add [PATCH] in $subject.. minor comment follows:

>
> Signed-off-by: Robert Nelson<robertcnelson@gmail.com>
> Signed-off-by: Koen Kooi<koen@beagleboard.org>
> ---
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 7c82730..4fd73e7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -58,7 +58,8 @@
> * AXBX = GPIO173, GPIO172, GPIO171: 1 1 1
> * C1_3 = GPIO173, GPIO172, GPIO171: 1 1 0
> * C4 = GPIO173, GPIO172, GPIO171: 1 0 1
> - * XM = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMA = GPIO173, GPIO172, GPIO171: 0 0 0
> + * XMB = GPIO173, GPIO172, GPIO171: 0 0 1
> */
> enum {
> OMAP3BEAGLE_BOARD_UNKN = 0,
> @@ -117,7 +118,11 @@ static void __init omap3_beagle_init_rev(void)
> omap3_beagle_version = OMAP3BEAGLE_BOARD_C4;
> break;
> case 0:
> - printk(KERN_INFO "OMAP3 Beagle Rev: xM\n");
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM A\n");
> + omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> + break;
> + case 1:
> + printk(KERN_INFO "OMAP3 Beagle Rev: xM B\n");

could you replace printk(KERN_INFO with pr_info?
> omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
> break;
> default:
> --
> cgit v0.8.3.1-30-gff3a
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Regards,
Nishanth Menon