Re: [PATCH] omap3: Add basic support for 720MHz part

Nishanth Menon
2011-01-07T14:04:19Z

Premi, Sanjeev wrote, on 01/07/2011 07:50 AM:
>> -----Original Message-----
>> From: Menon, Nishanth
>> Sent: Friday, January 07, 2011 7:04 PM
>> To: Premi, Sanjeev
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH] omap3: Add basic support for 720MHz part
>>
>> Sanjeev Premi wrote, on 01/07/2011 07:07 AM:
>>> + if (omap3_has_720mhz()) {
>>> + pr_info("Enabled OPP corresponding to
>> 720MHz\n");
>>> +
>>> + omap34xx_opp_def_list[INDEX_MPU_720MHZ]
>>> + .default_available = true;
>>> + omap34xx_opp_def_list[INDEX_IVA_720MHZ]
>>> + .default_available = true;
>> for many reasons, I dont like this indexing - I am ok with
>> most part of
>> the patch otherwise - how about opp_enable(dev, freq) instead?
>
> I had thought about it, but opp_enable would have to be done after
> omap_init_opp_table(). Two factors led me to current implementation:
>
> 1) Numer of lines of code required to get same thing done one the
> opp table has been initialized.
>
> 2) The index definition and usage are localized in same file.

right - i will leave it to kevin to comment - IMHO both will work,
though (1) might be a little more elgant and resistant to future changes
to the table (I am not sure if there would be any, but what the heck.)

--
Regards,
Nishanth Menon