Re: [PATCH v4 1/3] omap3: beaglexm: fix EHCI power up GPIO dir

[Nishanth Menon <nm@ti.com>]

Aaro Koskinen had written, on 01/10/2011 06:44 AM, the following:
> Hi,
> 
> On Fri, 7 Jan 2011, Nishanth Menon wrote:
>> From: Koen Kooi <koen@beagleboard.org>
>>
>> EHCI enable power pin is inverted (active high) in comparison
>> to vanilla beagle which is active low. Handle this case conditionally.
>>
>> Without this fix, Beagle XM 4 port EHCI will not function and no
>> networking will be available
>>
>> [nm@ti.com: split up, added descriptive changelogs]
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> Signed-off-by: Koen Kooi <koen@beagleboard.org>
>> ---
>> arch/arm/mach-omap2/board-omap3beagle.c |    9 ++++++++-
>> 1 files changed, 8 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
>> b/arch/arm/mach-omap2/board-omap3beagle.c
>> index 6c12760..1b5aa7a 100644
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>> @@ -297,9 +297,16 @@ static int beagle_twl_gpio_setup(struct device *dev,
>>     gpio_request(gpio + 1, "EHCI_nOC");
>>     gpio_direction_input(gpio + 1);
>>
>> -    /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active 
>> low) */
>> +    /*
>> +     * TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
>> +     * high / others active low)
>> +     */
>>     gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
>>     gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> 
> This call should be deleted.

yikes. yep. thanks for catching.


-- 
Regards,
Nishanth Menon