Tony Lindgren had written, on 01/11/2011 05:23 PM, the following: [..] >> - >> - gpio_request(gpio + 1, "EHCI_nOC"); >> - gpio_direction_input(gpio + 1); >> + if (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XM) { >> + gpio_request(gpio + 1, "EHCI_nOC"); >> + gpio_direction_input(gpio + 1); >> + } > > The return value for gpio_request must be checked. Ack. we can go down two paths: a) I can redo this patch as in v6.patch (attached) OR b) we take this patch and do another one cleaning the function up - gpio-check.patch -- Regards, Nishanth Menon