Re: OMAP: DSS2: Common IRQ handler for all OMAPs

Tomi Valkeinen
2011-02-15T07:27:10Z

On Mon, 2011-02-14 at 22:28 -0600, Taneja, Archit wrote:
> Hi,
>
> On Monday 14 February 2011 08:00 PM, Balbi, Felipe wrote:
> > Hi,
> >
> > On Mon, Feb 14, 2011 at 04:21:47PM +0200, Tomi Valkeinen wrote:
> >> On Wed, 2011-02-02 at 08:56 +0000, archit taneja wrote:
> >>> OMAP2 has an irq line dedicated for DISPC interrupts, there is no DSI
> >>> on omap2.
> >>> OMAP3 has a common irq line for DISPC and DSI interrupts.
> >>> OMAP4 has seperate irq lines for DISPC and DSI Interrupts.
> >>>
> >>> Use dss_features to have a common DSS irq handler for all OMAP revisions.
> >>>
> >>> Also, use a member of the global dss structure to store the irq number
> >>> as it is used in 2 functions.
> >>
> >> It's good to remove the cpu_is_xxxx() calls, but I'm not quite sure
> >> about this patch...
> >>
> >> Could we use shared interrupt handlers here, so that dss.c would handle
> >> only DISPC interrupts (or should it be even in dispc.c?) and dsi.c would
> >> handle DSI interrupts?
>
> Could you elaborate this a bit more?

I meant something like this:

dispc.c:

dispc_init()
{
/* did we have a pdev for dispc? if not, this needs to be dss.pdev */
request_irq(platform_get_irq(dispc.pdev, 0), irq_handler, IRQF_SHARED, "dispc irq", foo);
}

irq_handler()
{
if (irq_can_be_shared) {
check if the irq is for us. exit if not;
}

handle;
}

dsi.c:

dsi_init()
{
request_irq(platform_get_irq(dsi.pdev, 0), irq_handler, IRQF_SHARED, "dsi irq", foo);
}

irq_handler()
{
if (irq_can_be_shared) {
check if the irq is for us. exit if not;
}

handle;
}

>
> >>
> >> On OMAP3 both dss.c and dsi.c would register to the same interrupt, and
> >> they would need to check if the interrupt was really for them. On OMAP4
> >> the code could be the same, even though the check is unnecessary.
>
> The code can't be exactly the same. The DSS_IRQSTATUS register used on
> OMAP3 doesn't exist on OMAP4. A read to this register on OMAP4 would
> cause a hang/crash.

Ok, we need a dss_feature bit for this then.

Tomi