Re: OMAP: DSS2: Common IRQ handler for all OMAPs

archit taneja
2011-02-15T08:29:45Z

Hi,

On Tuesday 15 February 2011 12:57 PM, Valkeinen, Tomi wrote:

<snip>

> I meant something like this:
>
> dispc.c:
>
> dispc_init()
> {
> /* did we have a pdev for dispc? if not, this needs to be dss.pdev */
> request_irq(platform_get_irq(dispc.pdev, 0), irq_handler, IRQF_SHARED, "dispc irq", foo);
> }
>
> irq_handler()
> {
> if (irq_can_be_shared) {
> check if the irq is for us. exit if not;
> }
>
> handle;
> }
>
> dsi.c:
>
> dsi_init()
> {
> request_irq(platform_get_irq(dsi.pdev, 0), irq_handler, IRQF_SHARED, "dsi irq", foo);
> }
>
> irq_handler()
> {
> if (irq_can_be_shared) {
> check if the irq is for us. exit if not;
> }
>
> handle;
> }
>

This approach looks clean, but isn't IRQF_SHARED used the other way
around. One irq line and multiple handlers?

Regards,
Archit