From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH resend] video: omap24xxcam: Fix compilation Date: Tue, 15 Feb 2011 14:17:48 +0200 Message-ID: <4D5A6EEC.5000908@maxwell.research.nokia.com> References: <1297068547-10635-1-git-send-email-weber@corscience.de> <4D5A6353.7040907@maxwell.research.nokia.com> <20110215113717.GN2570@legolas.emea.dhcp.ti.com> <4D5A672A.7040000@samsung.com> <4D5A6874.1080705@corscience.de> <20110215115349.GQ2570@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110215115349.GQ2570@legolas.emea.dhcp.ti.com> Sender: linux-kernel-owner@vger.kernel.org To: balbi@ti.com Cc: Thomas Weber , Sylwester Nawrocki , linux-omap@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , Tejun Heo , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Felipe Balbi wrote: > Hi, > > On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote: >> Hello Felipe, >> >> in include/linux/wait.h >> >> #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) > > aha, now I get it, so shouldn't the real fix be including > on , I mean, it's who uses a symbol > defined in , right ? Surprisingly many other files still don't seem to be affected. But this is actually a better solution (to include sched.h in wait.h). -- Sakari Ailus sakari.ailus@maxwell.research.nokia.com