From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Hema HK <hemahk@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [4/7 v2] usb: otg: OMAP4430: Add phy_suspend function pointer to
Date: Tue, 15 Feb 2011 15:18:40 +0300 [thread overview]
Message-ID: <4D5A6F20.5060109@ru.mvista.com> (raw)
In-Reply-To: <1297762958-26199-4-git-send-email-hemahk@ti.com>
Hello.
On 15-02-2011 12:42, Hema HK wrote:
The subject seems incomplete.
> From: Kalliguddi, Hema<hemahk@ti.com>
> Introduce the .phy_suspend function pointer to twl4030_usb_data structure.
> assign the function to it for both sdp board and panda boards.
> This will be used by the twl6030-usb transceiver driver.
> Signed-off-by: Hema HK<hemahk@ti.com>
> Cc: Felipe Balbi<balbi@ti.com>
> Cc: Tony Lindgren<tony@atomide.com>
[...]
> Index: linux-2.6/arch/arm/mach-omap2/board-4430sdp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/board-4430sdp.c
> +++ linux-2.6/arch/arm/mach-omap2/board-4430sdp.c
> @@ -272,6 +272,7 @@ static struct twl4030_usb_data omap4_usb
> .phy_exit = omap4430_phy_exit,
> .phy_power = omap4430_phy_power,
> .phy_set_clock = omap4430_phy_set_clk,
> + .phy_suspend = omap4430_phy_suspend,
> };
>
> static struct omap2_hsmmc_info mmc[] = {
> Index: linux-2.6/arch/arm/mach-omap2/board-omap4panda.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/board-omap4panda.c
> +++ linux-2.6/arch/arm/mach-omap2/board-omap4panda.c
> @@ -153,6 +153,7 @@ static struct twl4030_usb_data omap4_usb
> .phy_exit = omap4430_phy_exit,
> .phy_power = omap4430_phy_power,
> .phy_set_clock = omap4430_phy_set_clk,
> + .phy_suspend = omap4430_phy_suspend,
> };
>
> static struct omap2_hsmmc_info mmc[] = {
> Index: linux-2.6/arch/arm/plat-omap/include/plat/usb.h
> ===================================================================
> --- linux-2.6.orig/arch/arm/plat-omap/include/plat/usb.h
> +++ linux-2.6/arch/arm/plat-omap/include/plat/usb.h
> @@ -88,6 +88,7 @@ extern int omap4430_phy_power(struct dev
> extern int omap4430_phy_set_clk(struct device *dev, int on);
> extern int omap4430_phy_init(struct device *dev);
> extern int omap4430_phy_exit(struct device *dev);
> +extern int omap4430_phy_suspend(struct device *dev, int suspend);
I think this *extern* declaration should be a part of the previous patch.
> #endif
>
> Index: linux-2.6/include/linux/i2c/twl.h
> ===================================================================
> --- linux-2.6.orig/include/linux/i2c/twl.h
> +++ linux-2.6/include/linux/i2c/twl.h
> @@ -600,6 +600,8 @@ struct twl4030_usb_data {
> int (*phy_power)(struct device *dev, int iD, int on);
> /* enable/disable phy clocks */
> int (*phy_set_clock)(struct device *dev, int on);
> + /* suspend/resume of phy */
> + int (*phy_suspend)(struct device *dev, int suspend);
> };
I'd make the above the only change in this patch, and add all the other
changes into the previous patch (which then I'd change places with that one).
WBR, Sergei
next prev parent reply other threads:[~2011-02-15 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 9:42 [1/7 v2] usb: otg: enable regulator only on cable/device connect Hema HK
2011-02-15 9:42 ` [3/7 v2] usb: otg: OMAP4430: Introducing suspend function for power management Hema HK
[not found] ` <1297762958-26199-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2011-02-15 9:42 ` [2/7 v2] usb: otg: Remove one unnecessary I2C read request Hema HK
2011-02-15 9:42 ` [4/7 v2] usb: otg: OMAP4430: Add phy_suspend function pointer to Hema HK
2011-02-15 12:18 ` Sergei Shtylyov [this message]
[not found] ` <4D5A6F20.5060109-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-02-16 5:14 ` Hema Kalliguddi
[not found] ` <137f7a77ed983ac5f3d08eaea0b2bb66-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-16 11:36 ` Sergei Shtylyov
[not found] ` <4D5BB6BF.7050603-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-02-16 13:48 ` Hema Kalliguddi
2011-02-15 9:42 ` [5/7 v2] usb: otg: TWL6030: Introduce the twl6030_phy_suspend function Hema HK
[not found] ` <1297762958-26199-5-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2011-02-15 12:22 ` Sergei Shtylyov
2011-02-16 5:16 ` Hema Kalliguddi
2011-02-15 9:42 ` [6/7 v2] usb: otg: TWL6030 Save the last event in otg_transceiver Hema HK
2011-02-15 9:42 ` [7/7 v2] usb: musb: OMAP4430: Fix usb device detection if connected during boot Hema HK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5A6F20.5060109@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox