Re: [5/7 v2] usb: otg: TWL6030: Introduce the twl6030_phy_suspend function.

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 15-02-2011 12:42, Hema HK wrote:

> From: Kalliguddi, Hema<hemahk-l0cyMroinI0@public.gmane.org>

> Introduce the twl6030_phy_suspend function and assign to otg.set_suspend
> function pointer.
> This function is used by the musb-omap2430 platform driver
> during suspend/resume.

> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
> Cc: Felipe Balbi<balbi-l0cyMroinI0@public.gmane.org>

[...]

> Index: linux-2.6/drivers/usb/otg/twl6030-usb.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/otg/twl6030-usb.c
> +++ linux-2.6/drivers/usb/otg/twl6030-usb.c
> @@ -177,6 +177,20 @@ static void twl6030_phy_shutdown(struct
>   	pdata->phy_power(twl->dev, 0, 0);
>   }
>
> +static int twl6030_phy_suspend(struct otg_transceiver *x, int suspend)
> +{
> +	struct twl6030_usb *twl;
> +	struct device *dev;
> +	struct twl4030_usb_data *pdata;
> +
> +	twl = xceiv_to_twl(x);
> +	dev  = twl->dev;
> +	pdata = dev->platform_data;

    Why not do all the above in the intializers?

> +	pdata->phy_suspend(twl->dev, suspend);
> +
> +	return 0;
> +}
> +

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html