From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg() Date: Tue, 15 Feb 2011 16:38:32 +0300 Message-ID: <4D5A81D8.2080800@ru.mvista.com> References: <1297776033-8579-1-git-send-email-dacohen@gmail.com> <1297776033-8579-2-git-send-email-dacohen@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:52210 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089Ab1BONju (ORCPT ); Tue, 15 Feb 2011 08:39:50 -0500 Received: by bwz15 with SMTP id 15so435185bwz.19 for ; Tue, 15 Feb 2011 05:39:48 -0800 (PST) In-Reply-To: <1297776033-8579-2-git-send-email-dacohen@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: David Cohen Cc: Hiroshi.DOYU@nokia.com, tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hello. On 15-02-2011 16:20, David Cohen wrote: > IOMMU upper layer is already printing error message. OMAP2+ specific > layer may print error message only for debug purpose. > Signed-off-by: David Cohen > --- > arch/arm/mach-omap2/iommu2.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c > index 14ee686..4244a07 100644 > --- a/arch/arm/mach-omap2/iommu2.c > +++ b/arch/arm/mach-omap2/iommu2.c > @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj, u32 *ra) > da = iommu_read_reg(obj, MMU_FAULT_AD); > *ra = da; > > - dev_err(obj->dev, "%s:\tda:%08x ", __func__, da); > + dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da); Note that dev_dbg() will only print something if either DEBUG or CONFIG_DYNAMIC_DEBUG are defined... > > for (i = 0; i< ARRAY_SIZE(err_msg); i++) { > if (stat & (1<< i)) > - printk("%s ", err_msg[i]); > + printk(KERN_DEBUG "%s ", err_msg[i]); ... unlike printk(KERN_DEBUG...). You probably want to use pr_debug() instead. > } > - printk("\n"); > + printk(KERN_DEBUG "\n"); Here too... Although wait, it should be KERN_CONT instead! Debug levels are only attributed to the whole lines. WBR, Sergei