Re: [PATCH 0/4] OMAP4: DSS2: Adding fclk support for DPI interface

Tomi Valkeinen
2011-02-14T16:02:23Z

Hi,

On Thu, 2011-02-03 at 07:56 -0600, Murthy, Raghuveer wrote:
> - Adding dss_feature for DPLL fclk
> - Enabling pixel clock generation for DPI interface

A bit more description what the patch set is about would be nice. Also,
one line patch descriptions are a bit too short for anything else than
the most trivial patches.

Now to the actual patch contents:

DPLL is not a feature of the DSS, and I don't think we should have
dss_features for that. In fact, I think the whole DPLL code should be
moved from DSS to somewhere under arch/arm.

In a perfect world DSS could just set the dss_fck to whatever rate it
requires, but as the clock rate can only be set to certain rates, and we
need a precise control for the rate, some other method has to be in
place.

I am not sure what this method should be. Perhaps there is something in
the clock framework that could help us here, or perhaps we just need a
bunch of function pointers in the DSS's platform data which can be used
to configure the clock.

Tomi