RE: [PATCH 15/19] omap3+: sr: introduce notifier_control

Vishwanath Sripathy
2011-02-23T06:46:29Z

> -----Original Message-----
> From: Nishanth Menon [mailto:nm@ti.com]
> Sent: Sunday, February 20, 2011 10:20 AM
> To: Vishwanath Sripathy
> Cc: linux-omap; Tony Lindgren; Kevin Hilman
> Subject: Re: [PATCH 15/19] omap3+: sr: introduce notifier_control
>
> Vishwanath Sripathy wrote, on 02/19/2011 07:10 PM:
>
> >> +int sr_notifier_control(struct voltagedomain *voltdm, bool enable)
> >> +{
> >> + struct omap_sr *sr = _sr_lookup(voltdm);
> >> + u32 value = 0;
> >> + if (IS_ERR_OR_NULL(sr)) {
> >> + pr_warning("%s: sr corresponding to domain not found\n",
> >> + __func__);
> >> + return -EINVAL;
> >> + }
> >> + if (!sr->autocomp_active)
> >> + return -EINVAL;
> > Why you do you return here? Class driver should still be able to place
> > it's request even if sr is disabled though it will be effective only
after
> > sr is enabled.
>
> my intents were as following: which useful event would come without SR
> avs being enabled? what kind of event do you expect with the AVS
> disabled which is useful for class driver, whose clase init alone was
> called and not class enable?
The point I am making here is, why should SR class driver be prevented to
register for some events when SR is disabled? If it is prevented here,
then it needs to keep track that the request is denied and needs to make
the request again when SR is enabled later.

Vishwa

>
> --
> Regards,
> Nishanth Menon