From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
"Hilman, Kevin" <khilman@ti.com>
Subject: Re: [PATCH] omap: Move omap_hwmod_late_init() to mdesc->timer->init() code
Date: Wed, 23 Feb 2011 15:20:01 +0100 [thread overview]
Message-ID: <4D651791.8000900@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102230015480.22636@utopia.booyaka.com>
Salut Paul,
On 2/23/2011 8:18 AM, Paul Walmsley wrote:
> Hi Santosh,
>
> On Tue, 22 Feb 2011, Santosh Shilimkar wrote:
>
>> To adhere to recent early_init changes, commit '44dc0' made
>> omap_hwmod_late_init() to core_initcall to avoid ioremap() failures.
>>
>> Later 'e7c7d7' removed _mpu_rt_va population omap_hwmod_late_init()
>>
>> So now if we move the omap_hwmod_late_init() to mdesc->timer->init(),
>> timer1 should work with hwmod instead of any special hwmod settings.
>>
>> This was proposed by Paul Walmsley<paul@pwsan.com>
>
> thanks -- something like this series was what I had in mind to go to
> mainline:
>
> http://marc.info/?l=linux-omap&m=129844518908008&w=2
>
> This series is also available at the branch "hwmod_clockevent_2.6.39" of
> git://git.pwsan.com/linux-2.6.
>
> Ultimately, of course, it's up to Tony to decide what approach he wants to
> use...
This is indeed a little bit cleaner to init only the timer hwmod in the
timer code, but I'm still wondering it it worth the extra complexity.
As soon as we have one hwmod to initialize, why cannot we initialize the
whole list like before?
If tomorrow we want to handle PRCM and control module using hwmod, like
I'd like to do, we will have to init these hwmods early as well.
Even earlier that init_early for the control module at least.
And then we will have a bunch of different init paths from different
parts of the boot sequence that might become tricky to handle.
Regards,
Benoit
next prev parent reply other threads:[~2011-02-23 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 14:37 [PATCH] omap: Move omap_hwmod_late_init() to mdesc->timer->init() code Santosh Shilimkar
2011-02-22 16:49 ` Tony Lindgren
2011-02-23 5:42 ` Santosh Shilimkar
2011-02-23 7:18 ` Paul Walmsley
2011-02-23 14:20 ` Cousson, Benoit [this message]
2011-02-23 14:29 ` Santosh Shilimkar
2011-02-24 8:49 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D651791.8000900@ti.com \
--to=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox