Re: [PATCH v10 05/18] OMAP2,3 DSS2 Change driver name to omap_display

Cousson, Benoit
2011-02-28T14:55:12Z

On 2/28/2011 3:06 PM, Russell King - ARM Linux wrote:
> On Mon, Feb 28, 2011 at 02:38:32PM +0100, Cousson, Benoit wrote:
>> On 2/28/2011 1:13 PM, Russell King - ARM Linux wrote:
>>> On Mon, Feb 28, 2011 at 02:10:26PM +0200, Tomi Valkeinen wrote:
>>>> On Mon, 2011-02-28 at 05:36 -0600, Cousson, Benoit wrote:
>>>>> Cannot you use a device hierarchy then to do that?
>>>>> omap_dss/core
>>>>> omap_dss/dsi
>>>>> omap_dss/venc
>>>>>
>>>>> This is moreover the way the HW is done.
>>>>
>>>> Hmm, how would that work? The devices are platform devices, and they
>>>> have a unique global name, which is used to match the driver for the
>>>> device.
>>>
>>> And not forgetting that '/' is not permitted in device or driver names.
>>
>> I was not really considering naming the device with a '/'. The idea is
>> that the devices will not longer be flat platform devices but something
>> like dss devices that will have have a omap_dss parent.
>>
>> I do not know if that makes sense to store some kind of hierarchy in the
>> device model, but encoding the hierarchy in the name like it is proposed
>> looks like a hack to me.
>
> Try:
>
> tree -d /sys/devices/pci0000\:00
>
> on your PC, taking special note of how pci-to-pci bridges are handled.

Here it is, but I'm not sure to understand how it is really done :-(

/sys/devices/pci0000:00
├── 0000:00:00.0
│ ├── firmware_node -> ../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/PNP0C02:00
│ ├── power
│ └── subsystem -> ../../../bus/pci
├── 0000:00:02.0
│ ├── 0000:00:02.0:pcie01
│ │ ├── power
│ │ └── subsystem -> ../../../../bus/pci_express
│ ├── 0000:00:02.0:pcie02
│ │ ├── driver -> ../../../../bus/pci_express/drivers/aer
│ │ ├── power
│ │ └── subsystem -> ../../../../bus/pci_express
│ ├── 0000:06:00.0
│ │ ├── 0000:06:00.0:pcie12
│ │ │ ├── power
│ │ │ └── subsystem -> ../../../../../bus/pci_express
│ │ ├── 0000:07:00.0
│ │ │ ├── 0000:07:00.0:pcie22
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../bus/pci_express
│ │ │ ├── 0000:08:00.0
│ │ │ │ ├── 0000:09:00.0
│ │ │ │ │ ├── driver -> ../../../../../../../bus/pci/drivers/bnx2
│ │ │ │ │ ├── net
│ │ │ │ │ │ └── eth1
│ │ │ │ │ │ ├── device -> ../../../0000:09:00.0
│ │ │ │ │ │ ├── power
│ │ │ │ │ │ ├── statistics
│ │ │ │ │ │ └── subsystem -> ../../../../../../../../../class/net
│ │ │ │ │ ├── power
│ │ │ │ │ └── subsystem -> ../../../../../../../bus/pci
│ │ │ │ ├── pci_bus
│ │ │ │ │ └── 0000:09
│ │ │ │ │ ├── device -> ../../../0000:08:00.0
│ │ │ │ │ ├── power
│ │ │ │ │ └── subsystem -> ../../../../../../../../class/pci_bus
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../bus/pci
│ │ │ ├── driver -> ../../../../../bus/pci/drivers/pcieport
│ │ │ ├── pci_bus
│ │ │ │ └── 0000:08
│ │ │ │ ├── device -> ../../../0000:07:00.0
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../../class/pci_bus
│ │ │ ├── power
│ │ │ └── subsystem -> ../../../../../bus/pci
...

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html