From: "Cousson, Benoit" <b-cousson@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>,
"Hilman, Kevin" <khilman@ti.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"Semwal, Sumit" <sumit.semwal@ti.com>,
"Guruswamy, Senthilvadivu" <svadivu@ti.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"Taneja, Archit" <archit@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v10 05/18] OMAP2,3 DSS2 Change driver name to omap_display
Date: Mon, 28 Feb 2011 15:55:00 +0100 [thread overview]
Message-ID: <4D6BB744.1010205@ti.com> (raw)
In-Reply-To: <20110228140617.GA2176@n2100.arm.linux.org.uk>
On 2/28/2011 3:06 PM, Russell King - ARM Linux wrote:
> On Mon, Feb 28, 2011 at 02:38:32PM +0100, Cousson, Benoit wrote:
>> On 2/28/2011 1:13 PM, Russell King - ARM Linux wrote:
>>> On Mon, Feb 28, 2011 at 02:10:26PM +0200, Tomi Valkeinen wrote:
>>>> On Mon, 2011-02-28 at 05:36 -0600, Cousson, Benoit wrote:
>>>>> Cannot you use a device hierarchy then to do that?
>>>>> omap_dss/core
>>>>> omap_dss/dsi
>>>>> omap_dss/venc
>>>>>
>>>>> This is moreover the way the HW is done.
>>>>
>>>> Hmm, how would that work? The devices are platform devices, and they
>>>> have a unique global name, which is used to match the driver for the
>>>> device.
>>>
>>> And not forgetting that '/' is not permitted in device or driver names.
>>
>> I was not really considering naming the device with a '/'. The idea is
>> that the devices will not longer be flat platform devices but something
>> like dss devices that will have have a omap_dss parent.
>>
>> I do not know if that makes sense to store some kind of hierarchy in the
>> device model, but encoding the hierarchy in the name like it is proposed
>> looks like a hack to me.
>
> Try:
>
> tree -d /sys/devices/pci0000\:00
>
> on your PC, taking special note of how pci-to-pci bridges are handled.
Here it is, but I'm not sure to understand how it is really done :-(
/sys/devices/pci0000:00
├── 0000:00:00.0
│ ├── firmware_node -> ../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/PNP0C02:00
│ ├── power
│ └── subsystem -> ../../../bus/pci
├── 0000:00:02.0
│ ├── 0000:00:02.0:pcie01
│ │ ├── power
│ │ └── subsystem -> ../../../../bus/pci_express
│ ├── 0000:00:02.0:pcie02
│ │ ├── driver -> ../../../../bus/pci_express/drivers/aer
│ │ ├── power
│ │ └── subsystem -> ../../../../bus/pci_express
│ ├── 0000:06:00.0
│ │ ├── 0000:06:00.0:pcie12
│ │ │ ├── power
│ │ │ └── subsystem -> ../../../../../bus/pci_express
│ │ ├── 0000:07:00.0
│ │ │ ├── 0000:07:00.0:pcie22
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../bus/pci_express
│ │ │ ├── 0000:08:00.0
│ │ │ │ ├── 0000:09:00.0
│ │ │ │ │ ├── driver -> ../../../../../../../bus/pci/drivers/bnx2
│ │ │ │ │ ├── net
│ │ │ │ │ │ └── eth1
│ │ │ │ │ │ ├── device -> ../../../0000:09:00.0
│ │ │ │ │ │ ├── power
│ │ │ │ │ │ ├── statistics
│ │ │ │ │ │ └── subsystem -> ../../../../../../../../../class/net
│ │ │ │ │ ├── power
│ │ │ │ │ └── subsystem -> ../../../../../../../bus/pci
│ │ │ │ ├── pci_bus
│ │ │ │ │ └── 0000:09
│ │ │ │ │ ├── device -> ../../../0000:08:00.0
│ │ │ │ │ ├── power
│ │ │ │ │ └── subsystem -> ../../../../../../../../class/pci_bus
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../bus/pci
│ │ │ ├── driver -> ../../../../../bus/pci/drivers/pcieport
│ │ │ ├── pci_bus
│ │ │ │ └── 0000:08
│ │ │ │ ├── device -> ../../../0000:07:00.0
│ │ │ │ ├── power
│ │ │ │ └── subsystem -> ../../../../../../../class/pci_bus
│ │ │ ├── power
│ │ │ └── subsystem -> ../../../../../bus/pci
...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-28 14:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 6:21 [PATCH v10 00/18] OMAP2,3: hwmod DSS Adaptation Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 01/18] OMAP2,3: DSS2: remove forced clk-disable from omap_dss_remove Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 02/18] OMAP2420: hwmod data: add DSS DISPC RFBI VENC Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 03/18] OMAP2430: " Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 04/18] OMAP3: hwmod data: add DSS DISPC RFBI DSI VENC Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 05/18] OMAP2,3 DSS2 Change driver name to omap_display Sumit Semwal
2011-02-24 9:27 ` Tomi Valkeinen
2011-02-28 6:53 ` Tomi Valkeinen
2011-02-28 7:09 ` archit taneja
2011-02-28 7:19 ` Tomi Valkeinen
2011-02-28 7:27 ` archit taneja
2011-02-28 8:16 ` Semwal, Sumit
2011-02-28 8:29 ` Tomi Valkeinen
2011-02-28 11:36 ` Cousson, Benoit
2011-02-28 12:10 ` Tomi Valkeinen
2011-02-28 12:13 ` Russell King - ARM Linux
2011-02-28 13:38 ` Cousson, Benoit
2011-02-28 14:06 ` Russell King - ARM Linux
2011-02-28 14:55 ` Cousson, Benoit [this message]
2011-02-28 14:00 ` Cousson, Benoit
2011-02-28 14:57 ` Tomi Valkeinen
2011-03-01 10:18 ` Cousson, Benoit
2011-01-24 6:21 ` [PATCH v10 06/18] OMAP2,3 DSS2 Use Regulator init with driver name Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 07/18] OMAP2,3: DSS2: Create new file display.c for central dss driver registration Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 08/18] OMAP2,3: DSS2: board files: replace platform_device_register with omap_display_init() Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 09/18] OMAP2,3: DSS2: Build omap_device for each DSS HWIP Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 10/18] OMAP2,3: DSS2: DSS: create platform_driver, move init,exit to driver Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 11/18] OMAP2,3: DSS2: Move clocks from core driver to dss driver Sumit Semwal
2011-01-24 6:21 ` [PATCH v10 12/18] OMAP2,3: DSS2: RFBI: create platform_driver, move init,exit to driver Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 13/18] OMAP2,3: DSS2: DISPC: " Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 14/18] OMAP2,3: DSS2: VENC: " Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 15/18] OMAP2,3: DSS2: DSI: " Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 16/18] OMAP2,3: DSS2: replace printk with dev_dbg in init Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 17/18] OMAP2,3: DSS2: Use platform device to get baseaddr Sumit Semwal
2011-01-24 6:22 ` [PATCH v10 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device Sumit Semwal
2011-01-27 12:49 ` Raghuveer Murthy
2011-01-27 12:59 ` [PATCH v10 18/18] OMAP2, 3: " Russell King - ARM Linux
2011-01-27 13:04 ` Raghuveer Murthy
2011-01-27 15:23 ` Semwal, Sumit
2011-02-14 14:09 ` [PATCH v10 18/18] OMAP2,3: " Tomi Valkeinen
2011-02-14 18:35 ` Semwal, Sumit
2011-01-24 21:57 ` [PATCH v10 00/18] OMAP2,3: hwmod DSS Adaptation Kevin Hilman
2011-01-25 17:03 ` Tony Lindgren
2011-01-28 12:01 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6BB744.1010205@ti.com \
--to=b-cousson@ti.com \
--cc=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=sumit.semwal@ti.com \
--cc=svadivu@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox