From mboxrd@z Thu Jan 1 00:00:00 1970 From: archit taneja Subject: Re: [PATCH 1/3] OMAP: DSS2: Functions to request/release DSI VCs Date: Tue, 1 Mar 2011 10:51:48 +0530 Message-ID: <4D6C826C.4050403@ti.com> References: <1298882849-7432-1-git-send-email-archit@ti.com> <1298882849-7432-2-git-send-email-archit@ti.com> <1298902214.9809.109.camel@deskari> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:56752 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753851Ab1CAFTA (ORCPT ); Tue, 1 Mar 2011 00:19:00 -0500 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id p215IvLO011715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 28 Feb 2011 23:18:59 -0600 Received: from dbde70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id p215IufI027003 for ; Tue, 1 Mar 2011 10:48:56 +0530 (IST) In-Reply-To: <1298902214.9809.109.camel@deskari> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Valkeinen, Tomi" Cc: "linux-omap@vger.kernel.org" Hi, On Monday 28 February 2011 07:40 PM, Valkeinen, Tomi wrote: > On Mon, 2011-02-28 at 02:47 -0600, Taneja, Archit wrote: >> Introduce functions which request and release VC's. This will be used in panel >> drivers in their probes. >> >> omap_dsi_request_vc() takes in the pointer to the omap_dss_device, the VC_ID >> parameter which goes into the header of the DSI packets, and returns a Virtual >> channel number (or virtual channel register set) which it can use. >> >> omap_dsi_releae_vc() takes the omap_dss_device pointer and frees all VCs which >> were used by that device. >> >> Initialisation of VC parameters is done in dsi_init(). >> >> Signed-off-by: Archit Taneja >> --- >> arch/arm/plat-omap/include/plat/display.h | 3 ++ >> drivers/video/omap2/dss/dsi.c | 55 ++++++++++++++++++++++++++--- >> 2 files changed, 53 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/plat-omap/include/plat/display.h b/arch/arm/plat-omap/include/plat/display.h >> index d45f107..0057259 100644 >> --- a/arch/arm/plat-omap/include/plat/display.h >> +++ b/arch/arm/plat-omap/include/plat/display.h >> @@ -560,6 +560,9 @@ int omap_dsi_update(struct omap_dss_device *dssdev, >> int channel, >> u16 x, u16 y, u16 w, u16 h, >> void (*callback)(int, void *), void *data); >> +int omap_dsi_request_vc(struct omap_dss_device *dssdev, int vc_id, >> + int *channel); > > One more thing: > > In theory the vc_id could be given per transmission, when calling > dsi_vc_send_xxx() functions, like it is currently. > > But as the vc_id changes (probably) very rarely, it could be stored like > you do. But we should still have a separate function to set the vc_id, > without having to release and request the vc. I agree with this. Will make the change. Archit