From: archit taneja <archit@ti.com>
To: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 0/3]OMAP: DSS2: Abstract away DSI VC information from dsi panel drivers
Date: Wed, 2 Mar 2011 11:10:35 +0530 [thread overview]
Message-ID: <4D6DD853.7050707@ti.com> (raw)
In-Reply-To: <1298995002.2049.8.camel@deskari>
Hi,
On Tuesday 01 March 2011 09:26 PM, Valkeinen, Tomi wrote:
> On Tue, 2011-03-01 at 06:32 -0600, Taneja, Archit wrote:
>> The current DSI driver design requires the DSI panel driver to specify the
>> DSI Virtual Channel and the Panel Virtual Channel ID for the transfer of
>> commands and frame data. Out of these, only the second parameter is a property
>> of the Panel.
>>
>> The DSI Virtual Channel in use by the panel driver ideally shouldn't be provided
>> by the panel driver. The current design leads to the following issues:
>> -Multiple panels connected to the same DSI interface would be unaware of the
>> VC's in use.
>> -Hard coded Virtual Channel numbers in panel drivers which is not generic.
>> -No clean way of configuring DSI for panels which need atleast 2 DSI Virtual
>> Channels.
>> -No clean way of configuring DSI for the special case where a panel may have 2
>> or VC ID's corresponding to it.
>>
>> The panel driver should, instead, request for, and release DSI Virtual Channels
>> through calls to the DSI driver. The DSI driver should return VC numbers which
>> the panel can use. The panel driver then uses this VC to either send pixel data,
>> send commands and receive data from the panel. The DSI driver then automatically
>> configures the Virtual Channel source to either Video Port or L4 Slave Port.
>>
>> This patch set tries to achieve the above design, and make Panel Taal driver use
>> this approach.
>
> This patch set doesn't apply, and seems not to be based on Linus',
> Tony's or my tree. What is it based on?
>
This is based on your master with a few patches I posted on l-o before
which haven't been applied yet. I will make sure I mention the pending
patches required when I post the next version.
Archit
> You should always base the patches on top of a public tree before
> sending the patches. Otherwise it is difficult to apply those patches.
> Or clearly say the required patch sets, which have previously been sent
> for review, but not yet applied.
>
> Tomi
>
>
prev parent reply other threads:[~2011-03-02 5:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 12:32 [PATCH v2 0/3]OMAP: DSS2: Abstract away DSI VC information from dsi panel drivers Archit Taneja
2011-03-01 12:32 ` [PATCH 1/3] OMAP: DSS2: Functions to request/release DSI VCs Archit Taneja
2011-03-01 13:20 ` DebBarma, Tarun Kanti
2011-03-01 13:36 ` archit taneja
2011-03-01 16:09 ` Tomi Valkeinen
2011-03-01 12:32 ` [PATCH 2/3] OMAP: DSS2: Use request / release calls in Taal for DSI Virtual Channels Archit Taneja
2011-03-01 12:32 ` Archit Taneja
2011-03-01 12:34 ` archit taneja
2011-03-01 12:32 ` [PATCH 3/3] OMAP: DSS2: Taal: Use 2 DSI Virtual Channels for Taal Archit Taneja
2011-03-01 15:56 ` [PATCH v2 0/3]OMAP: DSS2: Abstract away DSI VC information from dsi panel drivers Tomi Valkeinen
2011-03-02 5:40 ` archit taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6DD853.7050707@ti.com \
--to=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox