From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Nishanth Menon <nm@ti.com>,
linux-omap <linux-omap@vger.kernel.org>, Kevin H <khilman@ti.com>,
Tony L <tony@atomide.com>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
tglx@linutronix.de
Subject: Re: [PATCH v2 10/18] omap3+: sr: call handler with interrupt disabled
Date: Wed, 02 Mar 2011 20:39:02 +0300 [thread overview]
Message-ID: <4D6E80B6.9090901@ru.mvista.com> (raw)
In-Reply-To: <4D6E4866.6070107@ru.mvista.com>
I wrote:
>> Request the handler irq such that there is no nesting for calls.
>> the notifiers are not expected to be nested, further the interrupt
>> events for status change should be handled prior to the next event
>> else there is a risk of loosing events.
>> Signed-off-by: Nishanth Menon<nm@ti.com>
>> ---
>> arch/arm/mach-omap2/smartreflex.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> diff --git a/arch/arm/mach-omap2/smartreflex.c
>> b/arch/arm/mach-omap2/smartreflex.c
>> index 99e4c4f..a4e9f2d 100644
>> --- a/arch/arm/mach-omap2/smartreflex.c
>> +++ b/arch/arm/mach-omap2/smartreflex.c
>> @@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info)
>> goto error;
>> }
>> ret = request_irq(sr_info->irq, sr_interrupt,
>> - 0, name, (void *)sr_info);
>> + IRQF_DISABLED, name, (void *)sr_info);
> Isn't this flag a nop now?
Indeed, it is, according to the comment in <linux/interrupt.h>. So what does
this patch really achieve?
WBR, Sergei
next prev parent reply other threads:[~2011-03-02 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 10:55 [PATCH v2 00/18] OMAP3+: PM: introduce SR class 1.5 Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 01/18] omap3: hwmod: add smartreflex irqs Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 02/18] omap3+: voltage: remove initial voltage Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 03/18] omap3+: voltage: remove spurious pr_notice for debugfs Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 04/18] omap3+: voltage: use IS_ERR_OR_NULL Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 05/18] omap3+: voltage: use volt_data pointer instead values Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 06/18] omap3+: voltage: add transdone apis Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 07/18] omap3+: sr: make notify independent of class Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 08/18] omap3+: sr: introduce class init,deinit and priv data Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 09/18] omap3+: sr: fix cosmetic indentation Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 10/18] omap3+: sr: call handler with interrupt disabled Nishanth Menon
2011-03-02 13:38 ` Sergei Shtylyov
2011-03-02 17:08 ` Nishanth Menon
2011-03-02 17:39 ` Sergei Shtylyov [this message]
2011-03-02 17:48 ` Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 11/18] omap3+: sr: disable interrupt by default Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 12/18] omap3+: sr: enable/disable SR only on need Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 13/18] omap3+: sr: introduce notifiers flags Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 14/18] omap3+: sr: introduce notifier_control Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 15/18] omap3+: sr: disable spamming interrupts Nishanth Menon
2011-03-02 13:45 ` Sergei Shtylyov
2011-03-02 17:00 ` Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 16/18] omap3+: sr: make enable path use volt_data pointer Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 17/18] omap3630+: sr: add support for class 1.5 Nishanth Menon
2011-03-02 10:55 ` [PATCH v2 18/18] omap3430: sr: class3: restrict cpu to run on Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6E80B6.9090901@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox