From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 09/19] omap3+: sr: introduce class init,deinit and priv data Date: Thu, 03 Mar 2011 06:11:36 +0530 Message-ID: <4D6EE3C0.8060202@ti.com> References: <1298116918-30744-1-git-send-email-nm@ti.com> <1298116918-30744-10-git-send-email-nm@ti.com> <87r5apvzfc.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:34822 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910Ab1CCAln (ORCPT ); Wed, 2 Mar 2011 19:41:43 -0500 Received: by mail-vw0-f53.google.com with SMTP id 8so563599vws.12 for ; Wed, 02 Mar 2011 16:41:42 -0800 (PST) In-Reply-To: <87r5apvzfc.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: linux-omap , Tony Lindgren Kevin Hilman wrote, on 03/03/2011 05:38 AM: > Nishanth Menon writes: > >> Certain class drivers such as class 1.5 drivers, will need specific >> notification that they have to be started up or stopped independent >> of smart reflex operation. They also may need private data to be >> used for operations of their own, provide the same. >> >> Signed-off-by: Nishanth Menon > > Basic principle looks fine, but some naming comments below... k, thx. > > [...] > >> diff --git a/arch/arm/plat-omap/include/plat/smartreflex.h b/arch/arm/plat-omap/include/plat/smartreflex.h >> index 6568c88..8b6ecd9 100644 >> --- a/arch/arm/plat-omap/include/plat/smartreflex.h >> +++ b/arch/arm/plat-omap/include/plat/smartreflex.h >> @@ -167,6 +167,8 @@ struct omap_sr_pmic_data { >> * >> * @enable: API to enable a particular class smaartreflex. >> * @disable: API to disable a particular class smartreflex. >> + * @class_init: API to do class specific initialization (optional) >> + * @class_deinit: API to do class specific initialization (optional) > > The 'class_' prefix here is not needed. ack. > > The changelog uses 'start' and 'stop' instead of init& deinit. I > prefer those names to [de]init. Would'nt start and stop cause confusion when mixed with existing enable/disable? does enable/start actually start the SR? intent here with init/deinit is to do class specific initialization or deinitialization. -- Regards, Nishanth Menon