From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: David Cohen <dacohen@gmail.com>
Cc: Hiroshi.DOYU@nokia.com, linux-omap@vger.kernel.org,
fernando.lugo@ti.com, linux-media@vger.kernel.org,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 2/3] omap3: change ISP's IOMMU da_start address
Date: Tue, 08 Mar 2011 16:06:08 +0200 [thread overview]
Message-ID: <4D7637D0.4010402@maxwell.research.nokia.com> (raw)
In-Reply-To: <1299588365-2749-3-git-send-email-dacohen@gmail.com>
David Cohen wrote:
> ISP doesn't consider 0x0 as a valid address, so it should explicitly
> exclude first page from allowed 'da' range.
>
> Signed-off-by: David Cohen <dacohen@gmail.com>
> ---
> arch/arm/mach-omap2/omap-iommu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c
> index 3fc5dc7..3bea489 100644
> --- a/arch/arm/mach-omap2/omap-iommu.c
> +++ b/arch/arm/mach-omap2/omap-iommu.c
> @@ -33,7 +33,7 @@ static struct iommu_device omap3_devices[] = {
> .name = "isp",
> .nr_tlb_entries = 8,
> .clk_name = "cam_ick",
> - .da_start = 0x0,
> + .da_start = 0x1000,
The NULL address is still valid for the MMU. Can the IOVMF_DA_ANON
mapping be specified by the API to be always non-NULL?
This way it would be possible to combine IOVMF_DA_FIXED and
IOVMF_DA_ANON mappings in the same IOMMU while still being able to rely
that IOVMF_DA_ANON mappings would always be non-NULL.
Regards,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-03-08 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 12:46 [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' David Cohen
2011-03-08 12:46 ` [PATCH 1/3] omap: iovmm: disallow mapping NULL address David Cohen
2011-03-08 18:06 ` Guzman Lugo, Fernando
2011-03-08 19:06 ` David Cohen
2011-03-08 19:53 ` Guzman Lugo, Fernando
2011-03-08 20:07 ` David Cohen
2011-03-08 12:46 ` [PATCH 2/3] omap3: change ISP's IOMMU da_start address David Cohen
2011-03-08 14:06 ` Sakari Ailus [this message]
2011-03-08 17:15 ` David Cohen
2011-03-08 12:46 ` [PATCH 3/3] omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON flags David Cohen
2011-03-08 17:59 ` Guzman Lugo, Fernando
2011-03-08 18:09 ` Hiroshi DOYU
2011-03-08 18:53 ` Guzman Lugo, Fernando
2011-03-08 18:57 ` David Cohen
2011-03-08 19:33 ` Guzman Lugo, Fernando
2011-03-08 19:46 ` David Cohen
2011-03-08 19:51 ` David Cohen
2011-03-08 12:49 ` [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7637D0.4010402@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=dacohen@gmail.com \
--cc=fernando.lugo@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).