public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Cc: "paul@pwsan.com" <paul@pwsan.com>,
	"Hilman, Kevin" <khilman@ti.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] OMAP3: wdtimer: Fix CORE idle transition
Date: Thu, 10 Mar 2011 12:22:48 +0100	[thread overview]
Message-ID: <4D78B488.1060507@ti.com> (raw)
In-Reply-To: <1299754448-24888-3-git-send-email-kalle.jokiniemi@nokia.com>

On 3/10/2011 11:54 AM, Kalle Jokiniemi wrote:
> From: Paul Walmsley<paul@pwsan.com>
>
> The HW superwised smart idle for wdtimer in OMAP3 prevents
> CORE power domain idle transitions. Disable it by swithing
> to SW supervised transitions.

We should probably highlight that this looks like a HW bug.
Smartidle and clockactivity are supposed to be supported by this module 
on OMAP3.

Some further investigation with TI HW folks are needed to understand that.

Regards,
Benoit

>
> Signed-off-by: Kalle Jokiniemi<kalle.jokiniemi@nokia.com>
> Signed-off-by: Paul Walmsley<paul@pwsan.com>
> ---
>   arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 196a834..a99a4f3 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -1293,6 +1293,7 @@ static struct omap_hwmod omap3xxx_wd_timer2_hwmod = {
>   	.slaves		= omap3xxx_wd_timer2_slaves,
>   	.slaves_cnt	= ARRAY_SIZE(omap3xxx_wd_timer2_slaves),
>   	.omap_chip	= OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> +	.flags		= HWMOD_SWSUP_SIDLE,
>   };
>
>   /* UART common */


  reply	other threads:[~2011-03-10 11:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 10:54 [PATCH 0/2] OMAP3: wdtimer: Fix CORE idle Kalle Jokiniemi
2011-03-10 10:54 ` [PATCH 1/2] Watchdog: omap_wdt: add fine grain runtime-pm Kalle Jokiniemi
2011-03-10 13:02   ` Paul Walmsley
2011-03-10 13:04     ` Paul Walmsley
2011-03-11  7:32       ` kalle.jokiniemi
2011-03-11  7:31     ` kalle.jokiniemi
2011-03-11  7:37     ` kalle.jokiniemi
2011-03-10 10:54 ` [PATCH 2/2] OMAP3: wdtimer: Fix CORE idle transition Kalle Jokiniemi
2011-03-10 11:22   ` Cousson, Benoit [this message]
2011-03-10 12:32     ` kalle.jokiniemi
2011-03-10 11:08 ` [PATCH 0/2] OMAP3: wdtimer: Fix CORE idle Paul Walmsley
  -- strict thread matches above, loose matches on Subject: below --
2011-03-10 12:10 [PATCH v2 " Kalle Jokiniemi
2011-03-10 12:10 ` [PATCH 2/2] OMAP3: wdtimer: Fix CORE idle transition Kalle Jokiniemi
2011-03-10 14:52   ` Paul Walmsley
2011-03-14 10:34     ` kalle.jokiniemi
2011-03-14 19:27       ` Paul Walmsley
2011-03-15  6:57         ` kalle.jokiniemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D78B488.1060507@ti.com \
    --to=b-cousson@ti.com \
    --cc=kalle.jokiniemi@nokia.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox