From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Fillinger, Michael" <m-fillinger@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: 2420 sDMA address mapping typo
Date: Tue, 15 Mar 2011 21:32:23 +0100 [thread overview]
Message-ID: <4D7FCCD7.7050604@ti.com> (raw)
In-Reply-To: <E8606C3FD412994585953171ED63A9340217F287D9@dnce01.ent.ti.com>
Salut Michael,
On 3/15/2011 5:44 PM, Fillinger, Michael wrote:
> Hi,
>
> There is a small issue introduced in 2.6.38 on the address space of sDMA for OMAP2420, which seems to be a mix of OMAP2& newer OMAP addresses :
>
> arch/arm/mach-omap2/omap_hwmod_2420_data.c
>
> static struct omap_hwmod_addr_space omap2420_dma_system_addrs[] = {
> {
> .pa_start = 0x48056000,
> .pa_end = 0x4a0560ff,
> .flags = ADDR_TYPE_RT
> },
> };
>
> pa_end should be 0x480560ff unless I'm mistaken.
Good catch, but the size is almost 4k to store all the channels.
The quick and dirty patch is:
- .pa_end = 0x4a0560ff,
+ .pa_end = 0x48056fff,
Thanks,
Benoit
next prev parent reply other threads:[~2011-03-15 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 16:44 2420 sDMA address mapping typo Fillinger, Michael
2011-03-15 20:32 ` Cousson, Benoit [this message]
2011-03-15 21:21 ` Paul Walmsley
2011-03-15 21:26 ` Cousson, Benoit
2011-03-15 22:24 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7FCCD7.7050604@ti.com \
--to=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=m-fillinger@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox