Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

On 28-03-2011 10:51, Kalle Jokiniemi wrote:

> The isp1704 usb tranceiver is used for charging and can be
> disabled when not in use. Provide the powering routine to
> the driver via platform data.

> Loosely based on earlier patches from Heikki Krogerus in
> Nokia N900 maemo kernel.

> Signed-off-by: Kalle Jokiniemi<kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> Cc: Heikki Krogerus<heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> ---
>   arch/arm/mach-omap2/board-rx51-peripherals.c |   27 ++++++++++++++++++++++++-
>   1 files changed, 25 insertions(+), 2 deletions(-)

> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index e75e240..8584dd8 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
[...]
> @@ -106,10 +109,30 @@ static struct spi_board_info rx51_peripherals_spi_board_info[] __initdata = {
>   	},
>   };
>
> +static void rx51_charger_set_power(bool on)
> +{
> +	gpio_set_value(RX51_USB_TRANSCEIVER_RST_GPIO, on);
> +}
> +
> +static struct isp1704_charger_data rx51_charger_data = {
> +	.set_power	= rx51_charger_set_power,
> +};
> +
>   static struct platform_device rx51_charger_device = {
> -	.name = "isp1704_charger",
> +	.name	= "isp1704_charger",
> +	.dev	= {
> +		.platform_data =&rx51_charger_data,
> +	},
>   };
>
> +static void __init rx51_charger_init(void)
> +{
> +	BUG_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> +		GPIOF_OUT_INIT_LOW, "isp1704_reset"));

    I'm not sure we should kill the machine if this fails...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html