Re: [PATCH 4/4] omap: musb: introduce default baord config

[Mike Rapoport <mike@compulab.co.il>]

On 04/27/11 07:23, Oleg Drokin wrote:
> Hello!
> 
> On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote:
>> -void __init usb_musb_init(struct omap_musb_board_data *board_data)
>> +static struct omap_musb_board_data musb_default_board_data = {
>> +	.interface_type		= MUSB_INTERFACE_ULPI,
>> +	.mode			= MUSB_OTG,
> 
> In fact can you make it more generic with ifdefs like this?
> (since there are tons of boards taht are client only or would like to be compiled in some other way):

I didn't want to change current functionality. The purpose of this patch is to
reduce amount of code shared among board files.
If certain board needs mode other than OTG it can still pass musb_board_data.

> +#ifdef CONFIG_USB_MUSB_OTG
> +       .mode                   = MUSB_OTG,
> +#elif defined(CONFIG_USB_MUSB_HDRC_HCD)
> +       .mode                   = MUSB_HOST,
> +#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)
> +       .mode                   = MUSB_PERIPHERAL,
> +#endif
> 
>> +	.power			= 100,
>> +};
>> +
> 
> Thanks!
> 
> Bye,
>     Oleg
> 


-- 
Sincerely yours,
Mike.