From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, lo-ml <linux-omap@vger.kernel.org>
Subject: Re: DSS pm_runtime problem
Date: Thu, 5 May 2011 19:03:24 +0200 [thread overview]
Message-ID: <4DC2D85C.5000001@ti.com> (raw)
In-Reply-To: <1304611189.30935.38.camel@deskari>
Hi Tomi,
On 5/5/2011 5:59 PM, Valkeinen, Tomi wrote:
> Hi Paul, Benoit,
>
> I've started testing pm runtime with DSS, and I encountered a problem.
>
> I'm using latest -rc5 as a base, and it looks like
> omap_hwmod:_wait_target_ready() does not succeed for dss_core hwmod.
> This causes _enable() to fail, but omap_device_enable_hwmods() does not
> check the return values so it looks like everything went well, until the
> driver crashes as the DSS HW module was off.
>
> Ideas about _wait_target_ready()? And omap_device_enable_hwmods() would
> need some fixing, I wasted quite a while debugging this =).
The wait_target_ready is waiting for the PRCM status. It the status does
not change, it is probably because some inputs clocks... like the
optional ones are not enabled.
In your case, you have to enable the DSS fck before calling into PM
runtime because hwmod does mark this clock as optional:-(
Regards,
Benoit
prev parent reply other threads:[~2011-05-05 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 15:59 DSS pm_runtime problem Tomi Valkeinen
2011-05-05 17:02 ` Tomi Valkeinen
2011-05-05 17:12 ` Cousson, Benoit
2011-05-05 17:03 ` Cousson, Benoit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2D85C.5000001@ti.com \
--to=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).