From: Igor Grinberg <grinberg@compulab.co.il>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "Munegowda, Keshava" <keshava_mgowda@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>, "Gadiyar, Anand" <gadiyar@ti.com>,
"parthab@india.ti.com" <parthab@india.ti.com>
Subject: Re: [PATCH 3/5] arm: omap: usb: device name change for the clk names of usbhs
Date: Thu, 12 May 2011 14:28:04 +0300 [thread overview]
Message-ID: <4DCBC444.10506@compulab.co.il> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024CE66B4A@dbde02.ent.ti.com>
On 05/12/11 13:49, Premi, Sanjeev wrote:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org
>> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
>> Munegowda, Keshava
>> Sent: Wednesday, May 11, 2011 7:35 PM
>> To: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org
>> Cc: Munegowda, Keshava; Balbi, Felipe; Gadiyar, Anand;
>> parthab@india.ti.com
>> Subject: [PATCH 3/5] arm: omap: usb: device name change for
>> the clk names of usbhs
> [snip]...[snip]
>
>> --- a/drivers/mfd/omap-usb-host.c
>> +++ b/drivers/mfd/omap-usb-host.c
>> @@ -27,7 +27,7 @@
>> #include <linux/gpio.h>
>> #include <plat/usb.h>
>>
>> -#define USBHS_DRIVER_NAME "usbhs-omap"
>> +#define USBHS_DRIVER_NAME "usbhs_omap"
>> #define OMAP_EHCI_DEVICE "ehci-omap"
>> #define OMAP_OHCI_DEVICE "ohci-omap3"
>
> [sp] Shouldn't we be consistent in using minus/dash and
> underscore in the device names?
Also, can't we avoid once again changing the clock names
(at least for a while...)?
Is that really necessary? Can't hwmod use current clock names?
Because, Linus is sooo happy each time he sees that kind of changes....
--
Regards,
Igor.
next prev parent reply other threads:[~2011-05-12 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 14:04 [PATCH 0/5] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers Keshava Munegowda
[not found] ` <1305122676-27236-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-11 14:04 ` [PATCH 1/5] arm: omap: usb: ehci and ohci hwmod structures for omap3 and omap4 Keshava Munegowda
[not found] ` <1305122676-27236-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-11 14:04 ` [PATCH 2/5] arm: omap: usb: register hwmods of usbhs Keshava Munegowda
2011-05-11 14:04 ` [PATCH 3/5] arm: omap: usb: device name change for the clk names " Keshava Munegowda
[not found] ` <1305122676-27236-4-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-11 14:04 ` [PATCH 4/5] arm: omap: usb: Runtime PM support Keshava Munegowda
2011-05-11 14:04 ` [PATCH 5/5] arm: omap: usb: global Suspend and resume support of ehci and ohci Keshava Munegowda
2011-05-12 10:49 ` [PATCH 3/5] arm: omap: usb: device name change for the clk names of usbhs Premi, Sanjeev
2011-05-12 11:28 ` Igor Grinberg [this message]
2011-05-13 6:34 ` Munegowda, Keshava
[not found] ` <BANLkTin0hU95m5msSge_TYDPc774i4rGpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-13 9:05 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024CF130EB-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2011-05-13 9:40 ` Munegowda, Keshava
2011-05-13 11:01 ` [PATCH 0/5] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBC444.10506@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).