From: Igor Grinberg <grinberg@compulab.co.il>
To: Tasslehoff Kjappfot <tasskjapp@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] free rev gpios when they are read, so others can read them later
Date: Fri, 27 May 2011 14:28:09 +0300 [thread overview]
Message-ID: <4DDF8AC9.60709@compulab.co.il> (raw)
In-Reply-To: <2DCF0893-4166-4604-887B-EDBC3643290A@gmail.com>
Hi Tasslehoff,
On 05/26/11 22:59, Tasslehoff Kjappfot wrote:
> A script of mine that reads the rev gpios on the beagleboard started failing when I upgraded to .37, since board-omap3beagle.c doesn´t free the rev gpios after using them.
>
> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ff3a2c..8a4ac43 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
> beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
> | (gpio_get_value(173) << 2);
>
> + gpio_free_array(omap3_beagle_rev_gpios,
> + ARRAY_SIZE(omap3_beagle_rev_gpios));
> +
To be consistent with the rest of the file,
can the white space here be "tabs" instead of spaces?
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-27 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1306438716-68265-1-git-send-email-tasskjapp@gmail.com>
2011-05-26 19:59 ` [PATCH] free rev gpios when they are read, so others can read them later Tasslehoff Kjappfot
2011-05-27 11:28 ` Igor Grinberg [this message]
2011-05-28 9:24 ` Tasslehoff Kjappfot
2011-05-31 12:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDF8AC9.60709@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-omap@vger.kernel.org \
--cc=tasskjapp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).