[PATCH] free rev gpios when they are read, so others can read them later

[PATCH] free rev gpios when they are read, so others can read them later

[Tasslehoff Kjappfot]

A script of mine that reads the rev gpios on the beagleboard started failing when I upgraded to .37, since board-omap3beagle.c doesn´t free the rev gpios after using them.

Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
---
arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 3ff3a2c..8a4ac43 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
	beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
			| (gpio_get_value(173) << 2);

+        gpio_free_array(omap3_beagle_rev_gpios,
+                        ARRAY_SIZE(omap3_beagle_rev_gpios));
+
	switch (beagle_rev) {
	case 7:
		printk(KERN_INFO "OMAP3 Beagle Rev: Ax/Bx\n");
-- 
1.7.3.1


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] free rev gpios when they are read, so others can read them later

[Igor Grinberg]

Hi Tasslehoff,

On 05/26/11 22:59, Tasslehoff Kjappfot wrote:
> A script of mine that reads the rev gpios on the beagleboard started failing when I upgraded to .37, since board-omap3beagle.c doesn´t free the rev gpios after using them.
>
> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ff3a2c..8a4ac43 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
> 	beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
> 			| (gpio_get_value(173) << 2);
>
> +        gpio_free_array(omap3_beagle_rev_gpios,
> +                        ARRAY_SIZE(omap3_beagle_rev_gpios));
> +

To be consistent with the rest of the file,
can the white space here be "tabs" instead of spaces?


-- 
Regards,
Igor.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] free rev gpios when they are read, so others can read them later

[Tasslehoff Kjappfot]

Hi Igor.
> 
> To be consistent with the rest of the file,
> can the white space here be "tabs" instead of spaces?
> 
> 
> -- 
> Regards,
> Igor.
> 

They can. New version attached. I'm don't know how to use git send-email to continue this thread with a comment to my patch, so it was done manually. Let me know if something else is less-than-optimal with my patches. Rookie contributor :)

Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
---
 arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 3ff3a2c..54dbb7dd 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
 	beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
 			| (gpio_get_value(173) << 2);
 
+	gpio_free_array(omap3_beagle_rev_gpios,
+			ARRAY_SIZE(omap3_beagle_rev_gpios));
+
 	switch (beagle_rev) {
 	case 7:
 		printk(KERN_INFO "OMAP3 Beagle Rev: Ax/Bx\n");
-- 
1.7.3.1

Re: [PATCH] free rev gpios when they are read, so others can read them later

[Tony Lindgren]

* Tasslehoff Kjappfot <tasskjapp@gmail.com> [110528 02:20]:
> Hi Igor.
> > 
> > To be consistent with the rest of the file,
> > can the white space here be "tabs" instead of spaces?
> > 
> > 
> > -- 
> > Regards,
> > Igor.
> > 
> 
> They can. New version attached. I'm don't know how to use git send-email to continue this thread with a comment to my patch, so it was done manually. Let me know if something else is less-than-optimal with my patches. Rookie contributor :)

Thanks applying to fixes with following description:

Free Beagle rev gpios when they are read, so others can read them later
 
Regards,

Tony

> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 3ff3a2c..54dbb7dd 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void)
>  	beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1)
>  			| (gpio_get_value(173) << 2);
>  
> +	gpio_free_array(omap3_beagle_rev_gpios,
> +			ARRAY_SIZE(omap3_beagle_rev_gpios));
> +
>  	switch (beagle_rev) {
>  	case 7:
>  		printk(KERN_INFO "OMAP3 Beagle Rev: Ax/Bx\n");
> -- 
> 1.7.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html