Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits

Kevin Hilman
2011-06-06T22:32:29Z

Colin Cross <ccross@android.com> writes:

> On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross <ccross@android.com> wrote:
>> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
>> causing only the last bit set to take effect, resulting in lost
>> wakeups when the GPIO controller is in idle.
>>
>> Replace direct writes to IRQWAKEN with writes to SETWKUENA and
>> CLEARWKUEN.
>>
>> Signed-off-by: Colin Cross <ccross@android.com>

[...]

>
> Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and
> CLEARWKUENA.

In my GPIO cleanups, I was wondering why the set/clear registers were
not used here. Todd, can you give the TRM version & reference for this?
I didn't find anything after a quick scan/search.

Thanks,

Kevin