From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: Kevin Hilman <khilman@ti.com>, Nishanth Menon <nm@ti.com>,
Mike Turquette <mturquette@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH pm_wip/cpufreq] OMAP2+: cpufreq: Enable all CPUs in shared policy mask
Date: Wed, 08 Jun 2011 11:31:37 +0530 [thread overview]
Message-ID: <4DEF1041.9020109@ti.com> (raw)
In-Reply-To: <20110607205752.GA11299@google.com>
On 6/8/2011 2:27 AM, Todd Poynor wrote:
> Enable all CPUs in the shared policy in the CPU init callback.
> Otherwise, the governor CPUFREQ_GOV_START event is invoked with
> a policy that only includes the first CPU, leaving other CPUs
> uninitialized by the governor.
>
> Signed-off-by: Todd Poynor<toddpoynor@google.com>
Looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/omap2plus-cpufreq.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 77efcb0..0fe4edb 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -166,7 +166,6 @@ static inline void freq_table_free(void)
> static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> {
> int result = 0;
> - static cpumask_var_t cpumask;
>
> mpu_clk = clk_get(NULL, mpu_clk_name);
> if (IS_ERR(mpu_clk))
> @@ -207,8 +206,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> */
> if (is_smp()) {
> policy->shared_type = CPUFREQ_SHARED_TYPE_ANY;
> - cpumask_or(cpumask, cpumask_of(policy->cpu), cpumask);
> - cpumask_copy(policy->cpus, cpumask);
> + cpumask_setall(policy->cpus);
> }
>
> /* FIXME: what's the actual transition time? */
prev parent reply other threads:[~2011-06-08 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 20:57 [PATCH pm_wip/cpufreq] OMAP2+: cpufreq: Enable all CPUs in shared policy mask Todd Poynor
2011-06-08 6:01 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEF1041.9020109@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=nm@ti.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox