Re: [PATCH][RFC] OMAP4: I2C : I2C context save

Shubhrajyoti
2011-07-06T06:21:58Z

On Wednesday 06 July 2011 12:01 AM, Kevin Hilman wrote:
> Shubhrajyoti<shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
>
>> On Monday 20 June 2011 09:05 PM, Kevin Hilman wrote:
>>> shubhrajyoti-l0cyMroinI0@public.gmane.org writes:
>>>
>>>> From: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>>>
>>>> Currently the OMAP4 doesnot hit device off still the
>>>> driver may have support for it.Adding support for the
>>>> same.
>>>>
>>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>> Please Cc linux-omap as this change to the hwmod data would go through
>>> Tony.
>> Yes , missed out.
>>> Also, please describe why this hwmod data change affects the problem
>>> described in the changelog.
>>>
>> After Andy's patch set
>>
>> static void omap_i2c_unidle(struct omap_i2c_dev *dev)
>> {
>> <snip>
>>
>> pm_runtime_get_sync(&pdev->dev);
>>
>> if (pdata->flags& OMAP_I2C_FLAG_RESET_REGS_POSTIDLE) {
>> omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
>> omap_i2c_write_reg(dev, OMAP_I2C_PSC_REG, dev->pscstate);
>> omap_i2c_write_reg(dev, OMAP_I2C_SCLL_REG, dev->scllstate);
>> omap_i2c_write_reg(dev, OMAP_I2C_SCLH_REG, dev->sclhstate);
>> omap_i2c_write_reg(dev, OMAP_I2C_BUF_REG, dev->bufstate);
>> omap_i2c_write_reg(dev, OMAP_I2C_SYSC_REG, dev->syscstate);
>> omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
>> omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);
>> }
>> dev->idle = 0;
>>
>> This is dependent on the flag, I am making it true for OMAP4 also.
> What I meant was: please describe this in the changelog. Without more
> detail, the hwmod change itself is not understandable.
Yes , will explain it in the change logs.
> Kevin