From: Tushar Behera <tushar.behera@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, tony@atomide.com, lethal@linux-sh.org,
linaro-dev@lists.linaro.org, patches@linaro.org,
Tomi Valkeinen <tomi.valkeinen@nokia.com>
Subject: Re: [PATCH 2/2] video: omap2: Compile omap2 support only when needed
Date: Tue, 21 Jun 2011 10:18:53 +0530 [thread overview]
Message-ID: <4E0022B5.9000500@linaro.org> (raw)
In-Reply-To: <1308575201.2076.57.camel@deskari>
Hi,
On Monday 20 June 2011 06:36 PM, Tomi Valkeinen wrote:
> On Mon, 2011-06-20 at 16:16 +0530, Tushar Behera wrote:
>> Currently display support for omap2 is selected by default and
>> it gets built for all the configurations.
>>
>> Instead of it being a built-in feature, it's compilation should
>> depend on the config option CONFIG_FB_OMAP2.
>
> No, I don't think so. omap2 directory contains vram, vrfb and omapdss,
> all of which can be used without omapfb driver. vram and vrfb can be
> even used without omapdss driver.
Even if I build the kernel with i386_defconfig, I get some compiled
files within drivers/video/omap2.
$ make ARCH=x86 i386_defconfig O=out_dir
$ make ARCH=x86 O=out_dir
$ ls out_dir/drivers/video/omap2
built-in.o displays modules.builtin modules.order
IMHO, drivers/video/omap2/ should not be compiled if the kernel is not
built for omap2.
>
> Is this patch fixing some real problem?
This patch does not fix any other problem.
>
> Tomi
>
>
--
Tushar Behera
next prev parent reply other threads:[~2011-06-21 4:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 10:45 [PATCH 0/2] video: Make omap2 support conditional Tushar Behera
2011-06-20 10:46 ` [PATCH 1/2] config: omap2+: force fb and dss support as built-in Tushar Behera
2011-06-20 12:07 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024D625A5C@dbde02.ent.ti.com>
2011-06-20 12:20 ` Russell King - ARM Linux
2011-06-20 12:24 ` Premi, Sanjeev
2011-06-20 13:04 ` Tomi Valkeinen
2011-06-21 5:00 ` Tushar Behera
2011-06-20 10:46 ` [PATCH 2/2] video: omap2: Compile omap2 support only when needed Tushar Behera
2011-06-20 13:06 ` Tomi Valkeinen
2011-06-21 4:48 ` Tushar Behera [this message]
[not found] ` <4E0022B5.9000500-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-21 5:24 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0022B5.9000500@linaro.org \
--to=tushar.behera@linaro.org \
--cc=lethal@linux-sh.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=tomi.valkeinen@nokia.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox