Re: [PATCH v2 0/7] Fix module-mode enable sequence on OMAP4

["Cousson, Benoit" <b-cousson@ti.com>]

On 6/24/2011 3:23 PM, Nayak, Rajendra wrote:
> On 6/24/2011 5:06 AM, Benoit Cousson wrote:
>> Hi Paul&   Rajendra,
>>
>> Here is an updated version of the series started by Rajendra.
>> I had to update it because this series is mandatory for the hwmod
>> modulemodule control series.
>> I rebased it on top of the various fixes done on hwmod framework
>> and to take advantage of the new clkdm attribute in omap_hwmod.
>> I thus added 2 new APIs to handle clockdomain from hwmod instead
>> of using the clockdomain done for clock.
>>
>> I drop the clockdomain control for optional clocks that is not
>> mandatory.
>
> There were also some locking issues with this series pointed out
> by Todd, for which I did a RFC patch to add a per-clkdm lock.
> Any thoughts on that? We might need that or something similar to
> prevent concurrent clkdm states being programmed, now that they
> are done from hwmod (with a per-hwmod lock held) instead of being
> earlier done from clk framework with a global lock held.

Oops, good point I forgot that one.
I'm fine with it, but I think Paul was wondering if one global lock for 
clockdomain will not be enough. For the moment, it is maybe safer to 
keep one lock per domain.
I'll add it for the next revision.

Thanks,
Benoit