Re: [PATCH 3/7] OMAP4: hwmod data: TEMP: Do not idle MMC1 & MMC2 after boot

["Cousson, Benoit" <b-cousson@ti.com>]

On 6/28/2011 2:17 AM, Hilman, Kevin wrote:
> Benoit Cousson<b-cousson@ti.com>  writes:
>
>> Since the MMC driver is not pm_runtime adapted, do not put
>> them in idle after boot.
>> It will allow the driver to work as expected until the migration
>> to pm_runtime.
>>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Paul Walmsley<paul@pwsan.com>
>> Cc: Rajendra Nayak<rnayak@ti.com>
>> ---
>>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> Similar is needed for OMAP3 as well to boot this series.

I'm still hoping to base that on top of the MMC pm_runtime series Balaji 
did to avoid all these hacks that Russell did not like:-)

Thanks for the test and fix. I'll update the series with your patch.

Benoit


>
> Kevin
>
>
>
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/om
> index dec1a38..aaa3201 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -3500,6 +3500,7 @@ static struct omap_hwmod omap3xxx_mmc1_hwmod = {
>          .slaves_cnt     = ARRAY_SIZE(omap3xxx_mmc1_slaves),
>          .class          =&omap34xx_mmc_class,
>          .omap_chip      = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> +       .flags          = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
>   };
>
>   /* MMC/SD/SDIO2 */
> @@ -3543,6 +3544,7 @@ static struct omap_hwmod omap3xxx_mmc2_hwmod = {
>          .slaves_cnt     = ARRAY_SIZE(omap3xxx_mmc2_slaves),
>          .class          =&omap34xx_mmc_class,
>          .omap_chip      = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> +       .flags          = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
>   };
>