From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Elaidi, Djamil" <d-elaidi@ti.com>
Cc: "paul@pwsan.com" <paul@pwsan.com>,
"Nayak, Rajendra" <rnayak@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag
Date: Fri, 1 Jul 2011 15:56:19 +0200 [thread overview]
Message-ID: <4E0DD203.9060501@ti.com> (raw)
In-Reply-To: <74583B8642AB8841B30447520659FCA901FB33D546@dnce01.ent.ti.com>
Hi Djamil,
On 7/1/2011 3:50 PM, Elaidi, Djamil wrote:
> Benoit,
>
> HSI has no RESET_STATUS bit in SYSCONFIG register.
Yes indeed, the RESETDONE is inside HSI_SYSSTATUS.
And this is what that flag is meaning: SYSS_HAS_RESET_STATUS, with the
SYSS prefix.
The other one will be SYSC_HAS_RESET_STATUS with the SYSC prefix.
I know this is confusing, like the HW spec :-)
>
> The SYSC should be :
>
> static struct omap_hwmod_class_sysconfig omap44xx_hsi_sysc = {
> .rev_offs = 0x0000,
> .sysc_offs = 0x0010,
> .syss_offs = 0x0014,
> .sysc_flags = (SYSC_HAS_AUTOIDLE | SYSC_HAS_EMUFREE |
> SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE |
> --- SYSC_HAS_SOFTRESET | SYSS_HAS_RESET_STATUS),
So these flags are fine.
Benoit
> +++ SYSC_HAS_SOFTRESET),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
> MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> .sysc_fields =&omap_hwmod_sysc_type1,
>
> Best regards
> Djamil ELAÏDI
> +33 (0)4 97 27 50 97
> Software Systems Engineer
> OMAP Platform Business Unit - PSI Modem Integration
> Texas Instruments
>
>
> Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920
>
> -----Original Message-----
>
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Cousson, Benoit
> Sent: jeudi 23 juin 2011 23:01
> To: paul@pwsan.com
> Cc: Nayak, Rajendra; linux-omap@vger.kernel.org; Cousson, Benoit
> Subject: [PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag
>
> Add the flag to every IPs that support it to allow the
> framework to enable it instead of the SMART_STANDBY default
> mode.
> Without that, an IP with busmaster capability will not
> be able to wakeup the interconnect at all.
>
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> Cc: Paul Walmsley<paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index f7f4840..c531611 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -661,7 +661,8 @@ static struct omap_hwmod_class_sysconfig omap44xx_aess_sysc = {
> .sysc_offs = 0x0010,
> .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> - MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
> + MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART |
> + MSTANDBY_SMART_WKUP),
> .sysc_fields =&omap_hwmod_sysc_type2,
> };
>
> @@ -2045,7 +2046,7 @@ static struct omap_hwmod_class_sysconfig omap44xx_hsi_sysc = {
> SYSC_HAS_SOFTRESET | SYSS_HAS_RESET_STATUS),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
> - MSTANDBY_SMART),
> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> .sysc_fields =&omap_hwmod_sysc_type1,
> };
>
> @@ -2447,7 +2448,7 @@ static struct omap_hwmod_class_sysconfig omap44xx_iss_sysc = {
> SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
> - MSTANDBY_SMART),
> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> .sysc_fields =&omap_hwmod_sysc_type2,
> };
>
> @@ -3421,7 +3422,7 @@ static struct omap_hwmod_class_sysconfig omap44xx_mmc_sysc = {
> SYSC_HAS_SOFTRESET),
> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO |
> - MSTANDBY_SMART),
> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
> .sysc_fields =&omap_hwmod_sysc_type2,
> };
>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-01 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 21:00 [PATCH 0/6] OMAP2+: hwmod framework fixes Benoit Cousson
2011-06-23 21:00 ` [PATCH 1/6] OMAP2+: hwmod: Fix smart-standby + wakeup support Benoit Cousson
2011-06-23 21:00 ` [PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag Benoit Cousson
2011-07-01 13:50 ` Elaidi, Djamil
2011-07-01 13:56 ` Cousson, Benoit [this message]
2011-06-23 21:00 ` [PATCH 3/6] OMAP2+: hwmod: Enable module in shutdown to access sysconfig Benoit Cousson
2011-06-23 21:00 ` [PATCH 4/6] OMAP2+: hwmod: Do not write the enawakeup bit if SYSC_HAS_ENAWAKEUP is not set Benoit Cousson
2011-06-23 21:00 ` [PATCH 5/6] OMAP2+: hwmod: Remove _populate_mpu_rt_base warning Benoit Cousson
2011-06-23 21:00 ` [PATCH 6/6] OMAP2+: hwmod: Fix the HW reset management Benoit Cousson
2011-07-01 8:44 ` Paul Walmsley
2011-07-01 8:46 ` Cousson, Benoit
2011-07-01 8:41 ` [PATCH 0/6] OMAP2+: hwmod framework fixes Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DD203.9060501@ti.com \
--to=b-cousson@ti.com \
--cc=d-elaidi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox