From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Jan Weitzel <j.weitzel@phytec.de>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick
Date: Tue, 05 Jul 2011 11:42:15 -0700 [thread overview]
Message-ID: <4E135B07.80801@ti.com> (raw)
In-Reply-To: <87oc18r2y3.fsf@ti.com>
On 7/5/2011 11:35 AM, Kevin Hilman wrote:
> Santosh Shilimkar<santosh.shilimkar@ti.com> writes:
>
>> + Benoit
>>
>> On 7/5/2011 5:19 AM, Jan Weitzel wrote:
>>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in
>>> clock44xx_data.c
>>>
>>> Signed-off-by: Jan Weitzel<j.weitzel@phytec.de>
>> This happened after renaming the clock-nodes some time back.
>> Looks good to me as a fix though in long run GPMC should be
>> moved to hwmod to avoid such naming issues
>
> In fact, Benoit has already done it[1] as part of his last series:
> [PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2)
>
Ohh yes. I remember now about the discussion with him on the GPMC patch
which he did as a followup patch to mine similar clock framework
patch [1]
Thanks for the link.
Regards
Santosh
[1] https://patchwork.kernel.org/patch/937422/
prev parent reply other threads:[~2011-07-05 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 12:19 [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick Jan Weitzel
2011-07-05 16:49 ` Santosh Shilimkar
2011-07-05 18:35 ` Kevin Hilman
2011-07-05 18:42 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E135B07.80801@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=b-cousson@ti.com \
--cc=j.weitzel@phytec.de \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox