From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH] ARM: omap4: rename gpmc clock to gpmc_ick Date: Tue, 05 Jul 2011 11:42:15 -0700 Message-ID: <4E135B07.80801@ti.com> References: <1309868377-22379-1-git-send-email-j.weitzel@phytec.de> <4E1340AA.2020007@ti.com> <87oc18r2y3.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:40118 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab1GESmT (ORCPT ); Tue, 5 Jul 2011 14:42:19 -0400 Received: by mail-yx0-f169.google.com with SMTP id 22so2116471yxn.28 for ; Tue, 05 Jul 2011 11:42:18 -0700 (PDT) In-Reply-To: <87oc18r2y3.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Jan Weitzel , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, Benoit Cousson On 7/5/2011 11:35 AM, Kevin Hilman wrote: > Santosh Shilimkar writes: > >> + Benoit >> >> On 7/5/2011 5:19 AM, Jan Weitzel wrote: >>> The gpmc clock on omap44xx is called gpmc_ick not gpmc_ck in >>> clock44xx_data.c >>> >>> Signed-off-by: Jan Weitzel >> This happened after renaming the clock-nodes some time back. >> Looks good to me as a fix though in long run GPMC should be >> moved to hwmod to avoid such naming issues > > In fact, Benoit has already done it[1] as part of his last series: > [PATCH v2 0/4] OMAP4: Add modulemode support to hwmod framework (part 2) > Ohh yes. I remember now about the discussion with him on the GPMC patch which he did as a followup patch to mine similar clock framework patch [1] Thanks for the link. Regards Santosh [1] https://patchwork.kernel.org/patch/937422/